Re: [PATCHv3] Test ping w/o privileges

Hi Erik,

Erik Auerswald <[email protected]> writes:

> I have added macOS to the operating systems that do not need to skip
> the ping-localhost.sh test without root privileges, and plan to push
> the attached patch in a few days.

Looks good upon a quick glance from me. Sorry I didn't see the v2 patch.
Started a new job this week so I have been busy.

Also recently I did some work updating 'tests/init.sh' in a few GNU
projects which is pulled from Gnulib [1]. I'll probably get around to
adding that to Inetutils soon. It provides a mktemp function for systems
without the Coreutils command. And it simplifies the following idiom we
have currently:

INETD=${INETD:-../src/inetd$EXEEXT}

if [ ! -x $INETD ]; then
    echo "Missing executable '$INETD'.  Skipping test." >&2
    exit 77
fi

Becomes something like:

    . "${srcdir=.}/tests/init.sh"; path_prepend_ ./src

    # Now inetd is the built program.

Collin

[1] https://git.savannah.gnu.org/cgit/gnulib.git/tree/tests/init.sh