Re: ping, ping6: Fix mistake in previous change.

Simon Josefsson via Bug reports for the GNU Internet utilities <[email protected]> Thu, 18 Jul 2024 09:18:43 +0200

Newsgroups	gmane.comp.gnu.inetutils.bugs
Message-ID	<[email protected]>

Erik Auerswald <[email protected]> writes:

> Another was listed as successful, but it did not actually finish the build
> (it failed to build the telnet client):
> ArchLinux, <https://gitlab.com/gsasl/inetutils/-/jobs/7321035247>
>
> ```
> gcc -DHAVE_CONFIG_H -I. -I../../telnet -I..  -DTERMCAP -DLINEMODE
> -DKLUDGELINEMODE -DENV_HACK -I../../lib -I../lib -I../../libinetutils
> -I../..  -g -O2 -MT telnet.o -MD -MP -MF .deps/telnet.Tpo -c -o
> telnet.o ../../telnet/telnet.c
> ../../telnet/telnet.c: In function 'init_term':
> ../../telnet/telnet.c:767:9: error: implicit declaration of function
> 'tgetent'; did you mean 'getenv'? [-Wimplicit-function-declaration]
>   767 |   err = tgetent (termbuf, tname);
>       |         ^~~~~~~
>       |         getenv
> make[2]: Leaving directory '/builds/gsasl/inetutils/inetutils-2.5.36-d4dd/b/telnet'
> make[2]: *** [Makefile:2053: telnet.o] Error 1
> make[1]: Leaving directory '/builds/gsasl/inetutils/inetutils-2.5.36-d4dd/b'
> make[1]: *** [Makefile:2045: check-recursive] Error 1
> make: *** [Makefile:2344: check] Error 2
> ```

Since the CI/CD file had '|| true' I suppose it means it is a known
problem for ArchLinux.  Does anyone understand why the error above
happens?  ArchLinux shouldn't be that different, and tgetent should come
via ncurses which is detected fine...  anyway, since it is an earlier
known problem, I wouldn't worry about it since it is not a regression.
Would be nice to fix though, ArchLinux seems popular.

/Simon

signature.asc (application/pgp-signature, 255 B)