Re: [ftpd] documentation improvement request : mention the requirement for the /etc/shells file for proper user authentication

Erik Auerswald <[email protected]> Sun, 9 Nov 2025 09:16:24 +0100
Newsgroups gmane.comp.gnu.inetutils.bugs
Message-ID <[email protected]>
Hi all,

On Sat, Nov 08, 2025 at 12:43:05AM -0800, Collin Funk wrote:
> Erik Auerswald <[email protected]> writes:
> > [...]
> > I concur that "standard shell" is a bit terse, as I would not have
> > understood this to mean "usually listed in /etc/shells" either.  I intend
> > to push the attached patch soon, it expands point 3 of ftpd user
> > authentication to:
> >
> > ```
> >   3. The user must have a standard shell.  If the file '/etc/shells'
> >      exists and is readable, only programs listed there are considered
> >      standard shells.  'ftpd' uses the C library function 'getusershell'
> >      to enumerate standard shells.  Standard shells are also known as
> >      valid login shells, valid user shells, or permitted user shells.
> > ```
> 
> Looks good to me.

Thanks for the review.  I have just pushed this change.

> > [...]
> > While I can update the Texinfo documentation, and the online
> > documentation is created from this, AFAIK I cannot update the online
> > documentation.
> 
> You can since you are in the Savannah group. It is in a CVS repository [1].
> 
> But the online documentation should be updated as part of a new release.

OK, then the online documentation update will wait for a new release.

Cheers,
Erik