bug#75462: libtool wrongly reorder compiler deps on linux
Frederic Berat <[email protected]> Thu, 9 Jan 2025 22:23:14 +0100
| Newsgroups | gmane.comp.gnu.libtool.bugs |
|---|---|
| Message-ID | <CAObJKZrjgpjhbnj=NBAEkti6=asnDSkOAMzsLfO4aymFbQ6OdA@mail.gmail.com> |
--000000000000b281ee062b4c963c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jan 9, 2025 at 7:57=E2=80=AFPM Ileana Dumitrescu < [email protected]> wrote: > On 09/01/2025 15:11, Frederic Berat wrote: > > Hello, > > > > I opened an issue a few years back that didn't get solved: https:// > > lists.gnu.org/archive/html/libtool/2022-02/msg00001.html <https:// > > lists.gnu.org/archive/html/libtool/2022-02/msg00001.html> > > > > Out of curiosity, I decided to remove my local patch for it with the ne= w > > libtool release. It didn't take long for builds to fail again: > > https://bugzilla.redhat.com/show_bug.cgi?id=3D2331361 <https:// > > bugzilla.redhat.com/show_bug.cgi?id=3D2331361> > > > > Considering that more and more systems prevent deduplication over the > > years, may it be considered to be the default behavior instead of the > > exception ? > > To ensure GNU Libtool continues to work with older systems, this patch > should probably not be applied. Users can disable the deduplication > optimization with "--preserve-dup-deps" without applying the suggested > patch, but this affects more than just compiler generated dependencies. > > Well, I'm not sure I get why keeping duplicates would harm, but fair enough my patch is clearly overkill. > I would be more willing to add an option to toggle > "$opt_duplicate_compiler_generated_deps" separate from > "$opt_preserve_dup_deps". Would this be a good alternative to the patch? > Not sure that's a good alternative. you'd force users from the systems that have been excluded over the years to toggle an option that they didn't need so far. > > -- > Ileana Dumitrescu > > GPG Public Key: FA26 CA78 4BE1 8892 7F22 B99F 6570 EA01 146F 7354 > > --000000000000b281ee062b4c963c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g= mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Thu, Jan 9, = 2025 at 7:57=E2=80=AFPM Ileana Dumitrescu <<a href=3D"mailto:ileanadumit= [email protected]">[email protected]</a>> wrote:<br></div><bl= ockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-lef= t:1px solid rgb(204,204,204);padding-left:1ex">On 09/01/2025 15:11, Frederi= c Berat wrote:<br> > Hello,<br> > <br> > I opened an issue a few years back that didn't get solved: https:/= / <br> > <a href=3D"http://lists.gnu.org/archive/html/libtool/2022-02/msg00001.= html" rel=3D"noreferrer" target=3D"_blank">lists.gnu.org/archive/html/libto= ol/2022-02/msg00001.html</a> <https:// <br> > <a href=3D"http://lists.gnu.org/archive/html/libtool/2022-02/msg00001.= html" rel=3D"noreferrer" target=3D"_blank">lists.gnu.org/archive/html/libto= ol/2022-02/msg00001.html</a>><br> > <br> > Out of curiosity, I decided to remove my local patch for it with the n= ew <br> > libtool release. It didn't take long for builds to fail again:<br> > <a href=3D"https://bugzilla.redhat.com/show_bug.cgi?id=3D2331361" rel= =3D"noreferrer" target=3D"_blank">https://bugzilla.redhat.com/show_bug.cgi?= id=3D2331361</a> <https:// <br> > <a href=3D"http://bugzilla.redhat.com/show_bug.cgi?id=3D2331361" rel= =3D"noreferrer" target=3D"_blank">bugzilla.redhat.com/show_bug.cgi?id=3D233= 1361</a>><br> > <br> > Considering that more and more systems prevent deduplication over the = <br> > years, may it be considered to be the default behavior instead of the = <br> > exception ?<br> <br> To ensure GNU Libtool continues to work with older systems, this patch<br> should probably not be applied. Users can disable the deduplication<br> optimization with "--preserve-dup-deps" without applying the sugg= ested<br> patch, but this affects more than just compiler generated dependencies.<br> <br></blockquote><div><br></div><div>Well, I'm not sure I get why keepi= ng duplicates would harm, but fair enough my patch is clearly overkill.</di= v><div>=C2=A0<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0p= x 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> I would be more willing to add an option to toggle<br> "$opt_duplicate_compiler_generated_deps" separate from<br> "$opt_preserve_dup_deps". Would this be a good alternative to the= patch?<br></blockquote><div><br></div><div>Not sure that's a good alte= rnative. you'd force users from the systems that have been excluded ove= r the years to toggle an option that they didn't need so far. <br></div= ><div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px= 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <br> -- <br> Ileana Dumitrescu<br> <br> GPG Public Key: FA26 CA78 4BE1 8892 7F22 B99F 6570 EA01 146F 7354<br> <br> </blockquote></div></div> --000000000000b281ee062b4c963c--