Re: [PATCH] Support MSYS2
Peter Rosin <[email protected]>
| Newsgroups | gmane.comp.gnu.libtool.general,gmane.comp.gnu.mingw.user |
|---|---|
| Message-ID | <[email protected]> |
[ mingw-users: this is in reply to a suggested patch (1) ] On 2015-07-23 19:30, [email protected] wrote: > Hello, > when using the MSYS2 shell (http://msys2.github.io/), uname -o returns Msys instead of mingw32. The latest versions of config.guess and config.sub already support that, but Libtool doesn't. Here's a patch to add that support. This does not feel correct as a quick glance. Are you sure you understand what you are doing? In normal operation, I would have assumed that msys2 returns mingw-something and that any msys mode was a special case for building binaries with the cygwin/posix emulation layer, but you are adding msys to a bunch of places which are mingw-only. So, it all feels fishy. Also, how does this affect msys1? Cheers, Peter (1) http://lists.gnu.org/archive/html/libtool/2015-07/msg00003.html _______________________________________________ https://lists.gnu.org/mailman/listinfo/libtool