Re: -no_fixup_chains patch

Václav Haisman <[email protected]> Tue, 2 Jul 2024 21:01:06 +0200
Newsgroups gmane.comp.gnu.libtool.general
Message-ID <[email protected]>
On 28. 06. 24 0:41, Ozkan Sezer wrote:
> [Sorry, I seem to have deleted the mailing list message from my inbox]
> 
> Regarding -no_fixup_chains patch i.e.
>   http://git.savannah.gnu.org/gitweb/?p=libtool.git;a=commitdiff;h=3d1baeeef90a6b9e16c545babe833f28dca155a7
> 
> Is '+=' universally supported?? Maybe change to something like the following??

Is there a reason not to use AS_VAR_APPEND? 
(https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Polymorphic-Variables.html)

> 
> 
> diff --git a/m4/libtool.m4 b/m4/libtool.m4
> index 381d4cb..31f1be0 100644
> --- a/m4/libtool.m4
> +++ b/m4/libtool.m4
> @@ -1032,3 +1032,3 @@
>         [ save_LDFLAGS=$LDFLAGS
> -        LDFLAGS+=" -Wl,-no_fixup_chains"
> +        LDFLAGS="$LDFLAGS -Wl,-no_fixup_chains"
>           AC_LINK_IFELSE(
> @@ -1093,3 +1093,3 @@ _LT_EOF
>             if test yes = "$lt_cv_support_no_fixup_chains"; then
> -            _lt_dar_allow_undefined+=' $wl-no_fixup_chains'
> +            _lt_dar_allow_undefined='$_lt_dar_allow_undefined
> $wl-no_fixup_chains'
>             fi
> 

-- 
VH