Re: -no_fixup_chains patch

Ileana Dumitrescu <[email protected]> Wed, 3 Jul 2024 18:42:46 +0300

Newsgroups	gmane.comp.gnu.libtool.general
Message-ID	<[email protected]>

On 02/07/2024 22:01, Václav Haisman wrote:
> On 28. 06. 24 0:41, Ozkan Sezer wrote:
>> [Sorry, I seem to have deleted the mailing list message from my inbox]
>>
>> Regarding -no_fixup_chains patch i.e.
>>   
>> http://git.savannah.gnu.org/gitweb/?p=libtool.git;a=commitdiff;h=3d1baeeef90a6b9e16c545babe833f28dca155a7
>>
>> Is '+=' universally supported?? Maybe change to something like the 
>> following??
> 
> Is there a reason not to use AS_VAR_APPEND? 
> (https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Polymorphic-Variables.html)
> 

I do not think there is a reason not to, so I generated a patch for it:

diff --git a/m4/libtool.m4 b/m4/libtool.m4
index e9eef32f..36e5bf4e 100644
--- a/m4/libtool.m4
+++ b/m4/libtool.m4
@@ -1089,10 +1089,9 @@ _LT_EOF
          10.[[012]],*|,*powerpc*-darwin[[5-8]]*)
            _lt_dar_allow_undefined='$wl-flat_namespace $wl-undefined 
${wl}suppress' ;;
          *)
+          _lt_dar_allow_undefined='$wl-undefined ${wl}dynamic_lookup'
            if test yes = "$lt_cv_support_no_fixup_chains"; then
-            _lt_dar_allow_undefined='$wl-undefined ${wl}dynamic_lookup 
$wl-no_fixup_chains'
-          else
-            _lt_dar_allow_undefined='$wl-undefined ${wl}dynamic_lookup'
+            AS_VAR_APPEND([_lt_dar_allow_undefined], [' 
$wl-no_fixup_chains'])
            fi
          ;;
        esac
-- 

It should result in:
allow_undefined_flag="\$wl-undefined \${wl}dynamic_lookup 
\$wl-no_fixup_chains"

instead of:
allow_undefined_flag="\$_lt_dar_allow_undefined \$wl-no_fixup_chains"

Let me know what you both think.

>>
>> diff --git a/m4/libtool.m4 b/m4/libtool.m4
>> index 381d4cb..31f1be0 100644
>> --- a/m4/libtool.m4
>> +++ b/m4/libtool.m4
>> @@ -1032,3 +1032,3 @@
>>         [ save_LDFLAGS=$LDFLAGS
>> -        LDFLAGS+=" -Wl,-no_fixup_chains"
>> +        LDFLAGS="$LDFLAGS -Wl,-no_fixup_chains"
>>           AC_LINK_IFELSE(
>> @@ -1093,3 +1093,3 @@ _LT_EOF
>>             if test yes = "$lt_cv_support_no_fixup_chains"; then
>> -            _lt_dar_allow_undefined+=' $wl-no_fixup_chains'
>> +            _lt_dar_allow_undefined='$_lt_dar_allow_undefined
>> $wl-no_fixup_chains'
>>             fi
>>
> 

-- 
Ileana Dumitrescu

GPG Public Key: FA26 CA78 4BE1 8892 7F22 B99F 6570 EA01 146F 7354

0001-m4-Utilize-AS_VAR_APPEND.patch (text/x-patch, 1.2 KB)

From de453742b79726648ff5154fb8f5fb47b193a50c Mon Sep 17 00:00:00 2001
From: Ileana Dumitrescu <[email protected]>
Date: Wed, 3 Jul 2024 18:36:12 +0300
Subject: [PATCH] m4: Utilize AS_VAR_APPEND

* m4/libtool.m4: Instead of a conditional for using -no_fixup_chains,
  AC_VAR_APPEND will handle appending the option to the variable, which
  allows the '+=' extension to be used by shells that provide this
  capability for more efficient scaling.
---
 m4/libtool.m4 | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/m4/libtool.m4 b/m4/libtool.m4
index e9eef32f..36e5bf4e 100644
--- a/m4/libtool.m4
+++ b/m4/libtool.m4
@@ -1089,10 +1089,9 @@ _LT_EOF
         10.[[012]],*|,*powerpc*-darwin[[5-8]]*)
           _lt_dar_allow_undefined='$wl-flat_namespace $wl-undefined ${wl}suppress' ;;
         *)
+          _lt_dar_allow_undefined='$wl-undefined ${wl}dynamic_lookup'
           if test yes = "$lt_cv_support_no_fixup_chains"; then
-            _lt_dar_allow_undefined='$wl-undefined ${wl}dynamic_lookup $wl-no_fixup_chains'
-          else
-            _lt_dar_allow_undefined='$wl-undefined ${wl}dynamic_lookup'
+            AS_VAR_APPEND([_lt_dar_allow_undefined], [' $wl-no_fixup_chains'])
           fi
         ;;
       esac
-- 
2.45.1

OpenPGP_0x6570EA01146F7354.asc (application/pgp-keys, 6.3 KB)

OpenPGP_signature.asc (application/pgp-signature, 840 B)