Re: [PATCH] tests: skip with-pic test when no "real" pic flag is used.

Hi Peter,

On 19 ก.ย. 2012, at 15:56, Peter Rosin <[email protected]> wrote:

> * tests/with-pic.at: Windows uses "-DDLL_EXPORT -DPIC" as the pic
> "flag", but never applies it to static libraries. Cater for this
> and skip if no "real" pic flag is in use.
> [[...]]
> 
> Ok to push?

Yes, with nit below addressed. Thanks!

> I tried to eliminate the loop using variants of this:
> 
> real_pic=false
> case " $pic_flag " in
> *" "[^-]* | *" "-[^D]*) real_pic=: ;;
> esac
> AT_CHECK([$real_pic || exit 77])
> 
> ...but I never got that to work in the test. It worked in an
> interactive bash though. Strange.

M4 will strip one level of square brackets as it generates the testsuite script. Normally we just put an extra level of quoting around regexps/globs to account for that:

 [*" "[^-]* | *" "-[^D]*]) real_pic=: ;; 

(untested -- still on vacation ;-)

Cheers,
-- 
Gary V. Vaughan (gary AT gnu DOT org)