Re: [PATCH] tests: don't feed -no-undefined to the linker during, configure.

On 2012-09-19 21:25, Roumen Petrov wrote:
> Peter Rosin wrote:
>> * tests/deplibs-mingw.at: Restore LDFLAGS for the configure run so that
>> the linker does not see -no-undefined. Makes the test pass instead of
>> skip on MinGW.
>>
>> Signed-off-by: Peter Rosin <[email protected]>
>> ---
>>   tests/deplibs-mingw.at |    3 +++
>>   1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> Ok to push?
> No idea. It pass to me with git code , cross build, tested in emulated environment.

It's strange that you get a pass, if you have mingw.

Note that the test is a bit weird in that it passes instead
of skips on $host_os != mingw*, so are you sure you even get
into the inner configure with your setup? Because if you do,
your compiler must accept -no-undefined and that seems
unlikely to me.

Anyway, in my non-cross, non-emulated setup, the test skips on
line 79:

LT_AT_CONFIGURE([|| exit 77], ["$abs_top_srcdir"/configure])

where configure bombs out with the compiler not being able to
create executables (due to gcc not understanding -no-undefined).

So, the patch upgrades this completely bogus skip to a pass on
real MinGW.

Cheers,
Peter