Re: [PATCH] libtool: LT_PATH_NM: default to ${ac_tool_prefix}nm

On Sunday 28 April 2013 03:21:15 Peter Rosin wrote:
> On 2013-04-27 22:38, Mike Frysinger wrote:
> > On Saturday 27 April 2013 13:53:28 Peter Rosin wrote:
> >> On 2013-04-27 07:58, Mike Frysinger wrote:
> >>> The current code tries to locate a compatible nm tool.  It starts with
> >>> a prefixed nm tool (great!) and includes a plain nm too (that's fine).
> >>> The problem is that the code searches for the prefixed nm before the
> >>> plain nm (normally fine), but doesn't break once it has found a valid
> >>> match.  It does this so that it if it finds an "OK", but "not great",
> >>> tool, it'll keep on searching.
> >> 
> >> I agree this sounds like the wrong this to do, but isn't it better to
> >> just break all the way out when a "great" nm is found?
> > 
> > for some reason i thought the [n] arg to break wasn't portable.  this
> > should work though.
> > -mike
> 
> And on re-reading, my IFS changes are not very constructive. I removed
> those. I will push the attached in a couple of days, if there are no
> objections.

i actually thought your IFS changes made sense.  the current code 
saves/restores IFS around the inside loop, so if your code breaks out of both 
the inside and outside loop, then IFS won't get restored.
-mike

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)

iQIcBAABAgAGBQJRfd7EAAoJEEFjO5/oN/WB1asQAIyybjoofA/+7GsodVGQYzXT
Xvz2eBzNY9NEuYKJjf+8ESBnZjJdauv/u8we4zWjVfB+1lWSZvomxB0X0R3nhyXo
ZHKvkzlNGr5Cn6xewzvYPkyKfsP8GSXU+NGwZunwXVbsQce5jziIi0um8w9KyggF
U4+fRqJWRoI+sZ5273SKXiNGgOfCU2ZvvMqaUKwbQaaYnoYjMhOUSmi3p5iN/agP
YQOajxtBwrG94Lq0WSYkR3yDpXzkPhbfae8lHZecL4wUOK7JZz9eo716bgSS85UR
VXiWvF1MoEfJZM3d7vsHh1pIUlG2oADG7ob2RMzRmwSLZfapbdnu9ZjXYm8Qsln6
NjycXSFIoA8EnTVQVcuhaTWrRShrfA5cFJLdiUsgA5cXGlRkKaemBP0+LasB6G7z
mRApdxs0eiUvq7ENDTsgVqdMZzA2IjZVgQ9drZb30J4twDFh/k56BQW73uaAF2j4
FZStyLQ6rKZS7kPOFeBp8USJXvR6nmEcPrLvtv/0XZ0DFBUUgCtuFKhUzFxWthgz
5w1OXh+X6suivdNBhllG+yp2j6xnSpZfrkxYWYrYOjsemayEfMhj8kAaQX/7cmDD
430K8uWpGATBAKMM3O+gHq5YoL7PqDXJxhoRLOjML8uvyiVPmD2fDkn/6BwKr1LT
61qyxuFYzYUB3F1x0/NV
=aR6K
-----END PGP SIGNATURE-----