Re: [PATCH] Fix conversion warnings in cwrapper

On 2013-05-21 00:49, Yaakov (Cygwin/X) wrote:
> From: Yaakov Selkowitz <[email protected]>
> 
> Signed-off-by: Yaakov Selkowitz <[email protected]>
> ---
>  build-aux/ltmain.in |   18 +++++++++---------
>  1 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/build-aux/ltmain.in b/build-aux/ltmain.in
> index 4c56b98..3d1f5af 100644
> --- a/build-aux/ltmain.in
> +++ b/build-aux/ltmain.in
> @@ -3797,12 +3797,12 @@ main (int argc, char *argv[])
>    char *actual_cwrapper_name;
>    char *target_name;
>    char *lt_argv_zero;
> -  intptr_t rval = 127;
> +  int rval = 127;

*snip a bunch of type changes and casts*

I have no problem with this patch from a cursory look (haven't tested
it yet), but I will wait a couple of days with committing it to see
if Chuck (or someone else for that matter) has something to add.
Meanwhile, could we please have an update that also zap these lines
(inside a _MSC_VER #ifdef) as they are no longer needed?

# ifndef _INTPTR_T_DEFINED
#  define _INTPTR_T_DEFINED
#  define intptr_t int
# endif

Cheers,
Peter