Re: Bad IFS initialisation breaks gcc build of libsanitizer
"Gary V. Vaughan" <[email protected]>
| Newsgroups | gmane.comp.gnu.libtool.patches |
|---|---|
| Message-ID | <[email protected]> |
Hi Alan, On Aug 23, 2013, at 7:24 PM, Alan Modra <[email protected]> wrote: > Putting tab first in IFS breaks func_echo_all usage of $*, > resulting in failure of func_infer_tag to match a command line using a > $CC with trailing spaces. The trailing spaces were stripped out of > CC_expanded but words in $CC were separated by tabs. This didn't > match the makefile expansion of $CC using the standard IFS with a > first char of space. > > * gl/build-aux/funclib.sh (IFS): Make first char a space. Nice catch. Applied - funclib.sh is used by libtoolize too, so you've likely fixed a latent bug there as a bonus :) This situation came about due to a historical accident, where self tests prohibited <space><tab> by default (for obvious reasons), before we switched to sp=' '. Now that you point it out, I'm surprised it hasn't tripped us up sooner. Thanks for the patch. Cheers, -- Gary V. Vaughan (gary AT gnu DOT org)
signature.asc
(application/pgp-signature, 163 B)
-----BEGIN PGP SIGNATURE----- iEYEARECAAYFAlIXgD4ACgkQFRMICSmD1gYPKwCffpoeRMA9Y9RTVzz2kpQrdh4o j20Anj0IiEr5f4m7GpgrfAbzGA3S9lXS =I4l4 -----END PGP SIGNATURE-----