Re: Patch for mips64 libtool.m4
Brooks Moses <[email protected]>
| Newsgroups | gmane.comp.gnu.libtool.patches |
|---|---|
| Message-ID | <[email protected]> |
On 08/19/2013 02:35 PM, Steve Ellcey wrote:
> A user was trying to build the buildroot product for mips64 with the -mabi=64
> option and ran into a libtool problem when building libiscsi because it calls
> the linker via libtool and the linker was defaulting to the n32 ABI instead of
> the 64 bit ABI. This patch to libtool.m4 checks for the correct ABI to use
> like IA64, AIX, and other platforms already do and passes the correct emulation
> mode into the linker.
[...]
> +mips64*-*linux*)
[...]
> + LD="${LD} -m ${emul}"
A minor review comment: That should probably be ${LD-ld} to provide a
default linker name if $LD is not specified, to be consistent all the
other cases in this section.
- Brooks