Re: [patch #8675] elftoolchain strip support
Ed Maste <[email protected]>
| Newsgroups | gmane.comp.gnu.libtool.patches |
|---|---|
| Message-ID | <CAPyFy2Cc7_igOAZRm03Ed1bJb4=syiD2FtcnqE_=cHTA3d29gQ@mail.gmail.com> |
On 20 September 2015 at 12:12, Ed Maste <[email protected]> wrote: > On 27 May 2015 at 13:59, Ed Maste <[email protected]> wrote: >>> Currently libtool does not properly detect elftoolchain's version of strip(1). >>> The proposed patch fixes this. >> >> For reference, this issue has been discussed in FreeBSD at >> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198611 >> >> It's possible to simplify the test a little bit; $EGREP is already >> used in libtool.m4. This is what I had: >> >> --- a/m4/libtool.m4 >> +++ b/m4/libtool.m4 >> @@ -2207,7 +2207,8 @@ m4_defun([_LT_CMD_STRIPLIB], >> striplib= >> old_striplib= >> AC_MSG_CHECKING([whether stripping libraries is possible]) >> -if test -n "$STRIP" && $STRIP -V 2>&1 | $GREP "GNU strip" >/dev/null; then >> +if test -n "$STRIP" && $STRIP -V 2>&1 | >> + $EGREP "GNU strip|strip.*elftoolchain" >/dev/null; then >> test -z "$old_striplib" && old_striplib="$STRIP --strip-debug" >> test -z "$striplib" && striplib="$STRIP --strip-unneeded" >> AC_MSG_RESULT([yes]) > > Following up again to see about including this patch in libtool. Is > there anything else I can do to have this considered? Ping?