[patch #9999] Fix --preserve-dup-deps flag not to strip some duplicates

Follow-up Comment #3, patch #9999 (group libtool):

Many thanks!

I've had a look at the commit in the development branch.
I suggest to remove the comment "# Modification for INN in the loop (fix
--preserve-dup-deps)."

I had put it in our locally modified version of _ltmain.sh_ in INN so as to
remember the code differed here from upstream.  It is no longer necessary, now
it has been merged upstream.  I would then just remove the comment line.

Also, the "FIXME" could be removed.  The problem is fixed!


	  # FIXME: Pedantically, this is the right thing to do, so
	  #        that some nasty dependency loop isn't accidentally
	  #        broken: new_libs="$deplib $new_libs"
	  for deplib in $tmp_libs; do
	    # Modification for INN in the loop (fix --preserve-dup-deps).
	    if $opt_preserve_dup_deps; then
	      new_libs="$deplib $new_libs"


would become:


	  # Pedantically, this is the right thing to do, so
	  # that some nasty dependency loop isn't accidentally
	  # broken: new_libs="$deplib $new_libs"
	  for deplib in $tmp_libs; do
	    if $opt_preserve_dup_deps; then
	      new_libs="$deplib $new_libs"


Have a nice day.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?9999>

_______________________________________________
Message posté via Savannah
https://savannah.gnu.org/