bug#73493: [PATCH] Fix -single_module issues on recent macOS

Joshua Root <[email protected]> Thu, 26 Sep 2024 15:53:59 +1000
Newsgroups gmane.comp.gnu.libtool.bugs,gmane.comp.gnu.libtool.patches
Message-ID <[email protected]>
This is a multi-part message in MIME format.
--------------u0qae0TA8I1YWK08evnavIle
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Originally submitted at <https://savannah.gnu.org/support/?110937>.

The check for whether the linker supports the -single_module flag 
assumes that anything printed to stderr containing the string 
"single_module" means it is unsupported. Xcode 15 does print such a 
message, though it only indicates that the flag is deprecated. Lack of 
single module support triggers some workarounds that aren't needed and 
don't work very well on modern systems.

This flag has been unnecessary for many macOS versions, so teaching 
libtool that it is not needed in this case is probably preferable to 
just fixing the check.

- Josh
--------------u0qae0TA8I1YWK08evnavIle
Content-Type: text/plain; charset=UTF-8; name="single_module.diff"
Content-Disposition: attachment; filename="single_module.diff"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL05FV1MgYi9ORVdTCmluZGV4IGM4NTNkN2RiLi5iNTQyMGJiYyAxMDA2
NDQKLS0tIGEvTkVXUworKysgYi9ORVdTCkBAIC0yLDYgKzIsMTAgQEAgTkVXUyAtIGxpc3Qg
b2YgdXNlci12aXNpYmxlIGNoYW5nZXMgYmV0d2VlbiByZWxlYXNlcyBvZiBHTlUgTGlidG9v
bAogCiAqIE5vdGV3b3J0aHkgY2hhbmdlcyBpbiByZWxlYXNlID8uPyAoPz8/Py0/Py0/Pykg
Wz9dCiAKKyoqIEJ1ZyBmaXhlczoKKworICAtIEZpeCBpbmNvcnJlY3QgdXNlIG9mIHdvcmth
cm91bmRzIGRlc2lnbmVkIGZvciBEYXJ3aW4gdmVyc2lvbnMgdGhhdAorICAgIGRvbid0IGhh
dmUgLXNpbmdsZV9tb2R1bGUgc3VwcG9ydC4KIAogKiBOb3Rld29ydGh5IGNoYW5nZXMgaW4g
cmVsZWFzZSAyLjQuNyAoMjAyMi0wMy0xNikgW3N0YWJsZV0KIApkaWZmIC0tZ2l0IGEvbTQv
bGlidG9vbC5tNCBiL200L2xpYnRvb2wubTQKaW5kZXggNzlhMjQ1MWUuLjk3M2FiMmFhIDEw
MDY0NAotLS0gYS9tNC9saWJ0b29sLm00CisrKyBiL200L2xpYnRvb2wubTQKQEAgLTEwODEs
NiArMTA4MSwyMSBAQCBfTFRfRU9GCiAgICAgaWYgdGVzdCB5ZXMgPSAiJGx0X2N2X2FwcGxl
X2NjX3NpbmdsZV9tb2QiOyB0aGVuCiAgICAgICBfbHRfZGFyX3NpbmdsZV9tb2Q9JyRzaW5n
bGVfbW9kdWxlJwogICAgIGZpCisgICAgX2x0X2Rhcl9uZWVkc19zaW5nbGVfbW9kPW5vCisg
ICAgY2FzZSAkaG9zdF9vcyBpbgorICAgIHJoYXBzb2R5KiB8IGRhcndpbjEuKikKKyAgICAg
IF9sdF9kYXJfbmVlZHNfc2luZ2xlX21vZD15ZXMgOzsKKyAgICBkYXJ3aW4qKQorICAgICAg
IyBXaGVuIHRhcmdldGluZyBNYWMgT1MgWCAxMC40IChkYXJ3aW4gOCkgb3IgbGF0ZXIsCisg
ICAgICAjIC1zaW5nbGVfbW9kdWxlIGlzIHRoZSBkZWZhdWx0IGFuZCAtbXVsdGlfbW9kdWxl
IGlzIHVuc3VwcG9ydGVkLgorICAgICAgIyBUaGUgdG9vbGNoYWluIG9uIG1hY09TIDEwLjE0
IChkYXJ3aW4gMTgpIGFuZCBsYXRlciBjYW5ub3QKKyAgICAgICMgdGFyZ2V0IGFueSBPUyB2
ZXJzaW9uIHRoYXQgbmVlZHMgLXNpbmdsZV9tb2R1bGUuCisgICAgICBjYXNlICR7TUFDT1NY
X0RFUExPWU1FTlRfVEFSR0VULTEwLjB9LCRob3N0IGluCisgICAgICAxMC4wLCotZGFyd2lu
W1s1NjddXS4qfDEwLltbMC0zXV0sKi1kYXJ3aW5bWzUtOV1dLip8MTAuW1swLTNdXSwqLWRh
cndpbjFbWzAtN11dLiopCisgICAgICAgIF9sdF9kYXJfbmVlZHNfc2luZ2xlX21vZD15ZXMg
OzsKKyAgICAgIGVzYWMKKyAgICA7OworICAgIGVzYWMKICAgICBpZiB0ZXN0IHllcyA9ICIk
bHRfY3ZfbGRfZXhwb3J0ZWRfc3ltYm9sc19saXN0IjsgdGhlbgogICAgICAgX2x0X2Rhcl9l
eHBvcnRfc3ltcz0nICR3bC1leHBvcnRlZF9zeW1ib2xzX2xpc3QsJG91dHB1dF9vYmpkaXIv
JGxpYm5hbWUtc3ltYm9scy5leHBzeW0nCiAgICAgZWxzZQpAQCAtMTEyNiw3ICsxMTQxLDcg
QEAgbTRfZGVmdW4oW19MVF9EQVJXSU5fTElOS0VSX0ZFQVRVUkVTXSwKICAgICBfTFRfVEFH
VkFSKGFyY2hpdmVfZXhwc3ltX2NtZHMsICQxKT0iJFNFRCAnc3xefF98JyA8IFwkZXhwb3J0
X3N5bWJvbHMgPiBcJG91dHB1dF9vYmpkaXIvXCRsaWJuYW1lLXN5bWJvbHMuZXhwc3ltflwk
Q0MgLWR5bmFtaWNsaWIgXCRhbGxvd191bmRlZmluZWRfZmxhZyAtbyBcJGxpYiBcJGxpYm9i
anMgXCRkZXBsaWJzIFwkY29tcGlsZXJfZmxhZ3MgLWluc3RhbGxfbmFtZSBcJHJwYXRoL1wk
c29uYW1lIFwkdmVyc3RyaW5nICRfbHRfZGFyX3NpbmdsZV9tb2QkX2x0X2Rhcl9leHBvcnRf
c3ltcyRfbHRfZHN5bXV0aWwiCiAgICAgX0xUX1RBR1ZBUihtb2R1bGVfZXhwc3ltX2NtZHMs
ICQxKT0iJFNFRCAtZSAnc3xefF98JyA8IFwkZXhwb3J0X3N5bWJvbHMgPiBcJG91dHB1dF9v
YmpkaXIvXCRsaWJuYW1lLXN5bWJvbHMuZXhwc3ltflwkQ0MgXCRhbGxvd191bmRlZmluZWRf
ZmxhZyAtbyBcJGxpYiAtYnVuZGxlIFwkbGlib2JqcyBcJGRlcGxpYnMgXCRjb21waWxlcl9m
bGFncyRfbHRfZGFyX2V4cG9ydF9zeW1zJF9sdF9kc3ltdXRpbCIKICAgICBtNF9pZihbJDFd
LCBbQ1hYXSwKLVsgICBpZiB0ZXN0IHllcyAhPSAiJGx0X2N2X2FwcGxlX2NjX3NpbmdsZV9t
b2QiOyB0aGVuCitbICAgaWYgdGVzdCB5ZXMgPSAiJF9sdF9kYXJfbmVlZHNfc2luZ2xlX21v
ZCIgLWEgeWVzICE9ICIkbHRfY3ZfYXBwbGVfY2Nfc2luZ2xlX21vZCI7IHRoZW4KICAgICAg
IF9MVF9UQUdWQVIoYXJjaGl2ZV9jbWRzLCAkMSk9IlwkQ0MgLXIgLWtlZXBfcHJpdmF0ZV9l
eHRlcm5zIC1ub3N0ZGxpYiAtbyBcJGxpYi1tYXN0ZXIubyBcJGxpYm9ianN+XCRDQyAtZHlu
YW1pY2xpYiBcJGFsbG93X3VuZGVmaW5lZF9mbGFnIC1vIFwkbGliIFwkbGliLW1hc3Rlci5v
IFwkZGVwbGlicyBcJGNvbXBpbGVyX2ZsYWdzIC1pbnN0YWxsX25hbWUgXCRycGF0aC9cJHNv
bmFtZSBcJHZlcnN0cmluZyRfbHRfZHN5bXV0aWwiCiAgICAgICBfTFRfVEFHVkFSKGFyY2hp
dmVfZXhwc3ltX2NtZHMsICQxKT0iJFNFRCAnc3xefF98JyA8IFwkZXhwb3J0X3N5bWJvbHMg
PiBcJG91dHB1dF9vYmpkaXIvXCRsaWJuYW1lLXN5bWJvbHMuZXhwc3ltflwkQ0MgLXIgLWtl
ZXBfcHJpdmF0ZV9leHRlcm5zIC1ub3N0ZGxpYiAtbyBcJGxpYi1tYXN0ZXIubyBcJGxpYm9i
anN+XCRDQyAtZHluYW1pY2xpYiBcJGFsbG93X3VuZGVmaW5lZF9mbGFnIC1vIFwkbGliIFwk
bGliLW1hc3Rlci5vIFwkZGVwbGlicyBcJGNvbXBpbGVyX2ZsYWdzIC1pbnN0YWxsX25hbWUg
XCRycGF0aC9cJHNvbmFtZSBcJHZlcnN0cmluZyRfbHRfZGFyX2V4cG9ydF9zeW1zJF9sdF9k
c3ltdXRpbCIKICAgICBmaQo=

--------------u0qae0TA8I1YWK08evnavIle--