Re: [PATCH] libtool: Empty old_archive_from_new_cmds on OS/2

This is a multi-part message in MIME format.
--------------050703050604040108080009
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



Ileana Dumitrescu wrote:
> On 23/10/2025 16:16, KO Myung-Hun wrote:
>> Ping?
>> 
>> KO Myung-Hun wrote:
>>> old_archive_from_new_cmds is not used at all. In addition, if
>>> this is defined static libs are not generated.
>>> 
>>> This is a regression of commit e60044.
>>> 
>>> * m4/libtool.m4: Do not define old_archive_from_new_cmds on
>>> OS/2. --- m4/libtool.m4 | 6 +++--- 1 file changed, 3
>>> insertions(+), 3 deletions(-)
>>> 
>>> diff --git a/m4/libtool.m4 b/m4/libtool.m4 index
>>> 18c5fbcd..ea2c1808 100644 --- a/m4/libtool.m4 +++
>>> b/m4/libtool.m4 @@ -5313,7 +5313,7 @@ _LT_EOF cat
>>> $export_symbols | $prefix_cmds >> $output_objdir/$libname.def~ 
>>> $CC -Zdll -Zcrtdll -o $output_objdir/$soname $libobjs $deplibs 
>>> $compiler_flags $output_objdir/$libname.def~ emximp -o $lib
>>> $output_objdir/$libname.def' -
>>> _LT_TAGVAR(old_archive_from_new_cmds, $1)='emximp -o 
>>> $output_objdir/${libname}_dll.a $output_objdir/$libname.def' +
>>> #_LT_TAGVAR(old_archive_from_new_cmds, $1)='emximp -o 
>>> $output_objdir/${libname}_dll.a $output_objdir/$libname.def' 
>>> _LT_TAGVAR(enable_shared_with_static_runtimes, $1)=yes 
>>> _LT_TAGVAR(file_list_spec, $1)='@' ;; @@ -6029,7 +6029,7 @@
>>> _LT_EOF cat $export_symbols | $prefix_cmds >>
>>> $output_objdir/$libname.def~ $CC -Zdll -Zcrtdll -o
>>> $output_objdir/$soname $libobjs $deplibs $compiler_flags
>>> $output_objdir/$libname.def~ emximp -o $lib
>>> $output_objdir/$libname.def' -
>>> _LT_TAGVAR(old_archive_from_new_cmds, $1)='emximp -o 
>>> $output_objdir/${libname}_dll.a $output_objdir/$libname.def' +
>>> #_LT_TAGVAR(old_archive_from_new_cmds, $1)='emximp -o 
>>> $output_objdir/${libname}_dll.a $output_objdir/$libname.def' 
>>> _LT_TAGVAR(enable_shared_with_static_runtimes, $1)=yes 
>>> _LT_TAGVAR(file_list_spec, $1)='@' ;; @@ -6902,7 +6902,7 @@ if
>>> test yes != "$_lt_caught_CXX_error"; then cat $export_symbols |
>>> $prefix_cmds >> $output_objdir/$libname.def~ $CC -Zdll -Zcrtdll
>>> -o $output_objdir/$soname $libobjs $deplibs $compiler_flags
>>> $output_objdir/$libname.def~ emximp -o $lib
>>> $output_objdir/$libname.def' -
>>> _LT_TAGVAR(old_archive_from_new_cmds, $1)='emximp -o 
>>> $output_objdir/${libname}_dll.a $output_objdir/$libname.def' +
>>> #_LT_TAGVAR(old_archive_from_new_cmds, $1)='emximp -o 
>>> $output_objdir/${libname}_dll.a $output_objdir/$libname.def' 
>>> _LT_TAGVAR(enable_shared_with_static_runtimes, $1)=yes 
>>> _LT_TAGVAR(file_list_spec, $1)='@' ;;
> 
> Thank you for your patch! Sorry for not replying sooner, it was
> not delivered to my inbox. I think the lines should be removed
> instead of commented out if they are not needed. Can I apply your
> patch header with the lines removed?
> 

Here is the missed patch.

- -- 
KO Myung-Hun

Korean OS/2 User Community : https://www.os2.kr/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (OS/2)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIVAwUBaP2uc7bToKI+6WqcAQKMYxAAl5X6a5yAx6ZjjzIPi/c6KRAUq+jlzvFM
XjkcsZ11AOAQE9a3Vy/hIw8qiZ0bARUFw+S9Tz+npgXyGYBbzldecGim4Gc2F+YM
oUVEh8cyEujTIXjveafE2Jj5+FfeNy1i2/O0x+r2ux9IMgGENX4sI2k7zxxE+6Au
rK3/NUn8bLoeNMvWupGtxjyBfop+R5ZGjfvhecW89A79SNvoEEb3ardKBwr2mP8/
2ro5bH6A1wNPeEDqKJXw+ayM9SEddgwDxJlcJd72YtHyu3RIjNZOas0DmzEntsVj
tJIG0AkqzilB0ATxdDNdmyDAqFjbGQsekdFoHLFlbdCpzxbnjZj5ICf80LSZI5QU
RPJgV9XGUmhQ54EXkgVMMdRdhhN8sSAa+AcIsRi+XTnJtU+jElAHUba00XoG9SuN
iNjMrZDCFBoHlbhyNpAcnlt3WRq8sBSFbL5LVgAW6OV6r/XWzwWJe3ylcEguULY/
2lpM/85fIxjiGQ0ZSkOFNcPGyFzOy395C/2EOrIQIHqKQer1RjWIkJD+1Emt4OCm
RVn8h0Z0YAOb2hKs6j+5zB6xPUkk/f35vLhWurN7+oYuc05iUGxcR676KWiaiCzh
nTMZ08kQzFSNFsfXuZ7VjYIdx0pnL7X+d2ORuYPuHC9nLk5USQHrbu2+pTNS6oGB
CO0R6r3JvUo=
=qpAu
-----END PGP SIGNATURE-----

--------------050703050604040108080009
Content-Type: application/x-patch;
 name="0001-libtool-Remove-old_archive_from_new_cmds-on-OS-2.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename*0="0001-libtool-Remove-old_archive_from_new_cmds-on-OS-2.patch"

RnJvbSAwNTI2MTlhNmZkMmE0NTgyYWUxNTk1NzViNWI0NDdlZTQ5Mzk0ZTkyIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBLTyBNeXVuZy1IdW4gPGtvbWg3OEBnbWFpbC5jb20+
CkRhdGU6IFN1biwgOSBGZWIgMjAyNSAyMzoyMzozMCArMDkwMApTdWJqZWN0OiBbUEFUQ0hd
IGxpYnRvb2w6IFJlbW92ZSBvbGRfYXJjaGl2ZV9mcm9tX25ld19jbWRzIG9uIE9TLzIKCm9s
ZF9hcmNoaXZlX2Zyb21fbmV3X2NtZHMgaXMgbm90IHVzZWQgYXQgYWxsLiBJbiBhZGRpdGlv
biwgaWYgdGhpcyBpcwpkZWZpbmVkIHN0YXRpYyBsaWJzIGFyZSBub3QgZ2VuZXJhdGVkLgoK
VGhpcyBpcyBhIHJlZ3Jlc3Npb24gb2YgY29tbWl0IGU2MDA0NC4KCiogbTQvbGlidG9vbC5t
NDogUmVtb3ZlIG9sZF9hcmNoaXZlX2Zyb21fbmV3X2NtZHMgb24gT1MvMi4KLS0tCiBtNC9s
aWJ0b29sLm00IHwgMyAtLS0KIDEgZmlsZSBjaGFuZ2VkLCAzIGRlbGV0aW9ucygtKQoKZGlm
ZiAtLWdpdCBhL200L2xpYnRvb2wubTQgYi9tNC9saWJ0b29sLm00CmluZGV4IDIxOWVmZDY4
Li4zMDZjMmJiYiAxMDA2NDQKLS0tIGEvbTQvbGlidG9vbC5tNAorKysgYi9tNC9saWJ0b29s
Lm00CkBAIC01NDA4LDcgKzU0MDgsNiBAQCBfTFRfRU9GCiAJY2F0ICRleHBvcnRfc3ltYm9s
cyB8ICRwcmVmaXhfY21kcyA+PiAkb3V0cHV0X29iamRpci8kbGlibmFtZS5kZWZ+CiAJJEND
IC1aZGxsIC1aY3J0ZGxsIC1vICRvdXRwdXRfb2JqZGlyLyRzb25hbWUgJGxpYm9ianMgJGRl
cGxpYnMgJGNvbXBpbGVyX2ZsYWdzICRvdXRwdXRfb2JqZGlyLyRsaWJuYW1lLmRlZn4KIAll
bXhpbXAgLW8gJGxpYiAkb3V0cHV0X29iamRpci8kbGlibmFtZS5kZWYnCi0gICAgICBfTFRf
VEFHVkFSKG9sZF9hcmNoaXZlX2Zyb21fbmV3X2NtZHMsICQxKT0nZW14aW1wIC1vICRvdXRw
dXRfb2JqZGlyLyR7bGlibmFtZX1fZGxsLmEgJG91dHB1dF9vYmpkaXIvJGxpYm5hbWUuZGVm
JwogICAgICAgX0xUX1RBR1ZBUihlbmFibGVfc2hhcmVkX3dpdGhfc3RhdGljX3J1bnRpbWVz
LCAkMSk9eWVzCiAgICAgICBfTFRfVEFHVkFSKGZpbGVfbGlzdF9zcGVjLCAkMSk9J0AnCiAg
ICAgICA7OwpAQCAtNjEzMCw3ICs2MTI5LDYgQEAgX0xUX0VPRgogCWNhdCAkZXhwb3J0X3N5
bWJvbHMgfCAkcHJlZml4X2NtZHMgPj4gJG91dHB1dF9vYmpkaXIvJGxpYm5hbWUuZGVmfgog
CSRDQyAtWmRsbCAtWmNydGRsbCAtbyAkb3V0cHV0X29iamRpci8kc29uYW1lICRsaWJvYmpz
ICRkZXBsaWJzICRjb21waWxlcl9mbGFncyAkb3V0cHV0X29iamRpci8kbGlibmFtZS5kZWZ+
CiAJZW14aW1wIC1vICRsaWIgJG91dHB1dF9vYmpkaXIvJGxpYm5hbWUuZGVmJwotICAgICAg
X0xUX1RBR1ZBUihvbGRfYXJjaGl2ZV9mcm9tX25ld19jbWRzLCAkMSk9J2VteGltcCAtbyAk
b3V0cHV0X29iamRpci8ke2xpYm5hbWV9X2RsbC5hICRvdXRwdXRfb2JqZGlyLyRsaWJuYW1l
LmRlZicKICAgICAgIF9MVF9UQUdWQVIoZW5hYmxlX3NoYXJlZF93aXRoX3N0YXRpY19ydW50
aW1lcywgJDEpPXllcwogICAgICAgX0xUX1RBR1ZBUihmaWxlX2xpc3Rfc3BlYywgJDEpPSdA
JwogICAgICAgOzsKQEAgLTcwMDksNyArNzAwNyw2IEBAIGlmIHRlc3QgeWVzICE9ICIkX2x0
X2NhdWdodF9DWFhfZXJyb3IiOyB0aGVuCiAJICBjYXQgJGV4cG9ydF9zeW1ib2xzIHwgJHBy
ZWZpeF9jbWRzID4+ICRvdXRwdXRfb2JqZGlyLyRsaWJuYW1lLmRlZn4KIAkgICRDQyAtWmRs
bCAtWmNydGRsbCAtbyAkb3V0cHV0X29iamRpci8kc29uYW1lICRsaWJvYmpzICRkZXBsaWJz
ICRjb21waWxlcl9mbGFncyAkb3V0cHV0X29iamRpci8kbGlibmFtZS5kZWZ+CiAJICBlbXhp
bXAgLW8gJGxpYiAkb3V0cHV0X29iamRpci8kbGlibmFtZS5kZWYnCi0JX0xUX1RBR1ZBUihv
bGRfYXJjaGl2ZV9mcm9tX25ld19jbWRzLCAkMSk9J2VteGltcCAtbyAkb3V0cHV0X29iamRp
ci8ke2xpYm5hbWV9X2RsbC5hICRvdXRwdXRfb2JqZGlyLyRsaWJuYW1lLmRlZicKIAlfTFRf
VEFHVkFSKGVuYWJsZV9zaGFyZWRfd2l0aF9zdGF0aWNfcnVudGltZXMsICQxKT15ZXMKIAlf
TFRfVEFHVkFSKGZpbGVfbGlzdF9zcGVjLCAkMSk9J0AnCiAJOzsKLS0gCjIuNTAuMQoK
--------------050703050604040108080009--