Re: Crash in 2.25.4

On 2023-05-23 13:28, Jean Abou Samra wrote:
> <snipped>
>
> Colin: it's really hard to debug this remotely (we might have to resort to VNC or such, I'm afraid...) but there is one simple thing I would be interested in: if you apply this patch, recompile LilyPond and redo the test, what happens?
>
>
> ```
> diff --git a/lily/pango-font.cc b/lily/pango-font.cc
> index 7fc7c35207..8f0750c463 100644
> --- a/lily/pango-font.cc
> +++ b/lily/pango-font.cc
> @@ -523,7 +523,7 @@ Pango_font::text_stencil (Output_def * /* state */, const std::string &str,
>           = pango_attr_font_features_new (features_str.c_str ());
>         pango_attr_list_insert (list, features_attr);
>       }
> -  if (music_string)
> +  if (true)
>       {
>         // For music fonts, falling back to text fonts is surprising.
>         PangoAttribute *fallback_attr = pango_attr_fallback_new (false);
> ```


Patch applied to a fresh clone as Patch1. No errors on compiling 
lilypond, no errors on running lilypond against my test file. Resulting 
.PDF attached

Cheers,

Colin