Re: Missing_one1h_for bassoon_woodwind_diagram

Dear Werner.

Many thanks. The patch works fine.
I had to get a little around my installation. As I have Frescobaldi with Lilypond as Flatpack.
But I did it.

Regards
Eberhard

-- 
Eberhard Rennecke
Stettbachstr. 52
8051 Zürich

+41 44 3200065 (p)
+41 79 3312234 (m)

[email protected]

-----Original Message-----
From: Werner LEMBERG
To: [email protected]
Cc: [email protected]
Subject: Re: Missing_one1h_for bassoon_woodwind_diagram
Date: Mon, 21 Aug 2023 16:33:43 +0000 (UTC)

> The attached snippet provides the basic layout of the bassoon
> diagram.

Thanks.  Note that this can be done easier on the command line with

```
lilypond -e="(print-keys-verbose 'bassoon (current-output-port))" > bassoon-keys
```

> For one (left index finger) there must be more possibilities. At
> least one1h should be available.  But one1q and one3q with all
> combinations with T or F (similar to two (middle finger)).  I did
> not see a ring at this hole ever.

Please try the patch below (or change the file manually) and report
back whether this is sufficient.


    Werner


======================================================================


--- display-woodwind-diagrams.scm.orig  2023-07-22 14:00:54.734583384 +0200
+++ display-woodwind-diagrams.scm       2023-08-21 18:30:00.208824010 +0200
@@ -1362,7 +1362,7 @@
                   . ((offset . ,(assoc-get 'one CENTRAL-COLUMN-HOLE-PLACEMENTS))
                      (stencil . ,ring-column-circle-stencil)
                      (text? . #f)
-                     (complexity . trill)))
+                     (complexity . covered)))
                  (two
                   . ((offset . ,(assoc-get 'two CENTRAL-COLUMN-HOLE-PLACEMENTS))
                      (stencil . ,ring-column-circle-stencil)