Re: automatically setting 'Patch::review' for MRs?
Jonas Hahnfeld via Discussions on LilyPond development <[email protected]>
| Newsgroups | gmane.comp.gnu.lilypond.devel |
|---|---|
| Message-ID | <[email protected]> |
On Wed, 2025-07-23 at 03:25 +0000, Werner LEMBERG wrote:
> In section 1.3 of the CG ('Summary for experienced developers') we
> have the following item:
>
> 2. A Merge Request is usually automatically tested within an hour
> of submission. Once it has passed the basic tests – ‘make
> check’, ‘make’, ‘make doc’ – the tracker will be updated and
> the patch’s status will change to ‘Patch::review’ for other
> developers to examine.
>
> However, this automatic tracker update doesn't happen currently; we
> have to set 'Patch::review' manually.
>
> Does gitlab support such an automatical setting of a label? If yes,
> it would be great if this can be (re)activated. Otherwise we have to
> update the documentation...
As far as I remember, advancing to Patch::review was never automatic.
Since the introduction of automatic testing on GitLab, it was on a
human to check that the jobs ran correctly and passed. I don't see a
contradiction with the quoted item though: since it's a summary for
"external" contributors, I would just read it that somebody else (from
the team) advances the status. The last resort is the Patch Meister,
but can be anybody.
signature.asc
(application/pgp-signature, 228 B)
-----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRiF4DLRvon1vw5biCcVOmY/6OEDwUCaIPnWAAKCRCcVOmY/6OE D5JdAQCrnceFDCMwq5/AUX+JtMeWCjZfE2dS2gy1OrI6ccVXFQEAjWyGQ3sF46qG hDu2qzGMs37wrG0r2VH4iptqF5aY6gM= =CRXO -----END PGP SIGNATURE-----