Re: How to do add-on merge requests and get a pipeline to run?
David Kastrup <[email protected]>
| Newsgroups | gmane.comp.gnu.lilypond.devel |
|---|---|
| Message-ID | <[email protected]> |
Werner LEMBERG <[email protected]> writes: >>> As a told you: Let's assume MR #1 contains commits a, b, c, and MR >>> #2 commits d, e, f, and MR #2 depends on MR #1. To make the >>> pipeline run successfully for MR #2, copy commits a, b, c so that >>> MR#2 actually consists of a, b, c, d, e, f. This is tedious and >>> awkward to manage, I know, but better than waiting IMHO. >> >> Uh, there is a hard dependency. Of course the merge request branch >> contains all relevant commits. The diff is against its dependent >> branch which makes reviewing for humans easy, the snapshot contains >> every necessary change, and it is rebased so that exactly the same >> commits as the parent merge request branch are in the ancestry and >> of course in every work tree checkout. >> >> I think we are talking past one another. You can perfectly well >> check out merge request branch 3115 and compile it, and it will >> contain every single change in branch 3111 and every commit as well. > > Yeah, I know that. And still, gitlab apparently doesn't allow CI to > take care of this situation, thus my work-around suggestion. You just don't understand. CI jobs don't check the diffs of single commits, they check the work tree state of the branch end point. I cannot "copy commits a, b, c so that MR#2 actually consists of a, b, c, d, e, f." because MR #2 already consists of all those commits. What I could do is to make the upstream branch master. MR#2 would consist of exactly the same commits but the runner would start. But that would make the merge request garbage to review because the diff display would include all the dependencies of branch 3111 that aren't part of this merge request. > Maybe it is posible with some special code in the CI configuration for > LilyPond's git repository, I really don't know. Asking a search > machine didn't reveal anything that I can understand. One needs project maintainer role to set up CI triggers. As far as I can tell, the pipeline configuration is already the same as with normal merge requests though I don't know what that means with respect to the reference point for "make test-baseline". But I cannot trigger a pipeline. -- David Kastrup