RE: m4 patch requests
Mike Fulton <[email protected]> Sat, 24 Dec 2022 04:52:20 +0000
| Newsgroups | gmane.comp.gnu.m4.general |
|---|---|
| Message-ID | <BN8PR15MB30607C058906F2F31C015E7598EE9@BN8PR15MB3060.namprd15.prod.outlook.com> |
--_000_BN8PR15MB30607C058906F2F31C015E7598EE9BN8PR15MB3060namp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Hi Thank you Sam! Will do. Thanks, Mike On 2022-12-23, 20:43, "Sam James" <[email protected]> wrote: > On 24 Dec 2022, at 03:56, Mike Fulton <[email protected]<mailto:fultonm@= ca.ibm.com>> wrote: > > Hello, Hi Mike, > I am new to the m4 community and would like to understand the best way t= o propose a patch. > I have a few small changes I would like to request =96 one minor one wher= e there is a macro collision on z/OS where __stat is already defined, and t= wo others where I would like to add some z/OS specific code for conversion = to ASCII from EBCDIC. > I have a third where the error message from our runtime is =91<message nu= mber> No such file or directory=92 instead of just =91No such file or direc= tory=92. > What is the preferred way to propose these changes for the community? https://git.savannah.gnu.org/cgit/m4.git/tree/HACKING?h=3Dbranch-1.4 almost= covers it but not quite. I would follow the guidance in that file wrt style and such, and then send = patches to the m4-patches mailing list ([email protected]<mailto:[email protected]> <mailto:m4-patc= [email protected]<mailto:[email protected]>>) using git-send-email. Best, sam --_000_BN8PR15MB30607C058906F2F31C015E7598EE9BN8PR15MB3060namp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable <html xmlns:o=3D"urn:schemas-microsoft-com:office:office" xmlns:w=3D"urn:sc= hemas-microsoft-com:office:word" xmlns:m=3D"http://schemas.microsoft.com/of= fice/2004/12/omml" xmlns=3D"http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3DWindows-1= 252"> <meta name=3D"Generator" content=3D"Microsoft Word 15 (filtered medium)"> <style><!-- /* Font Definitions */ @font-face {font-family:"Cambria Math"; panose-1:2 4 5 3 5 4 6 3 2 4;} @font-face {font-family:Calibri; panose-1:2 15 5 2 2 2 4 3 2 4;} @font-face {font-family:"IBM Plex Sans"; panose-1:2 11 5 3 5 2 3 0 2 3;} @font-face {font-family:"Times New Roman \(Body CS\)"; panose-1:2 11 6 4 2 2 2 2 2 4;} /* Style Definitions */ p.MsoNormal, li.MsoNormal, div.MsoNormal {margin:0in; font-size:11.0pt; font-family:"Calibri",sans-serif;} a:link, span.MsoHyperlink {mso-style-priority:99; color:blue; text-decoration:underline;} span.EmailStyle18 {mso-style-type:personal-reply; font-family:"IBM Plex Sans",sans-serif; color:windowtext;} .MsoChpDefault {mso-style-type:export-only; font-size:10.0pt;} @page WordSection1 {size:8.5in 11.0in; margin:1.0in 1.0in 1.0in 1.0in;} div.WordSection1 {page:WordSection1;} --></style> </head> <body lang=3D"EN-CA" link=3D"blue" vlink=3D"purple" style=3D"word-wrap:brea= k-word"> <div class=3D"WordSection1"> <p class=3D"MsoNormal"><span style=3D"font-family:"IBM Plex Sans"= ,sans-serif">Hi<o:p></o:p></span></p> <p class=3D"MsoNormal"><span style=3D"font-family:"IBM Plex Sans"= ,sans-serif"><o:p> </o:p></span></p> <p class=3D"MsoNormal"><span style=3D"font-family:"IBM Plex Sans"= ,sans-serif">Thank you Sam! Will do.<o:p></o:p></span></p> <p class=3D"MsoNormal"><span style=3D"font-family:"IBM Plex Sans"= ,sans-serif"><o:p> </o:p></span></p> <div> <div> <div> <p class=3D"MsoNormal">Thanks, Mike <o:p></o:p></p> </div> </div> </div> <p class=3D"MsoNormal"><span style=3D"font-family:"IBM Plex Sans"= ,sans-serif"><o:p> </o:p></span></p> <p class=3D"MsoNormal"><span style=3D"font-family:"IBM Plex Sans"= ,sans-serif"><o:p> </o:p></span></p> <p class=3D"MsoNormal" style=3D"margin-bottom:12.0pt">On 2022-12-23, 20:43,= "Sam James" <[email protected]> wrote:<o:p></o:p></p> <div> <p class=3D"MsoNormal"><o:p> </o:p></p> </div> <div> <p class=3D"MsoNormal"><o:p> </o:p></p> </div> <div> <p class=3D"MsoNormal">> On 24 Dec 2022, at 03:56, Mike Fulton <<a hr= ef=3D"mailto:[email protected]">[email protected]</a>> wrote:<o:p></o:= p></p> </div> <div> <p class=3D"MsoNormal">> <o:p></o:p></p> </div> <div> <p class=3D"MsoNormal">> Hello,<o:p></o:p></p> </div> <div> <p class=3D"MsoNormal"><o:p> </o:p></p> </div> <div> <p class=3D"MsoNormal">Hi Mike,<o:p></o:p></p> </div> <div> <p class=3D"MsoNormal"><o:p> </o:p></p> </div> <div> <p class=3D"MsoNormal">> I am new to the m4 community and wou= ld like to understand the best way to propose a patch.<o:p></o:p></p> </div> <div> <p class=3D"MsoNormal">> I have a few small changes I would like to requ= est =96 one minor one where there is a macro collision on z/OS where __stat= is already defined, and two others where I would like to add some z/OS spe= cific code for conversion to ASCII from EBCDIC.<o:p></o:p></p> </div> <div> <p class=3D"MsoNormal">> I have a third where the error message from our= runtime is =91<message number> No such file or directory=92 instead = of just =91No such file or directory=92.<o:p></o:p></p> </div> <div> <p class=3D"MsoNormal">> What is the preferred way to propose= these changes for the community?<o:p></o:p></p> </div> <div> <p class=3D"MsoNormal"><o:p> </o:p></p> </div> <div> <p class=3D"MsoNormal"><a href=3D"https://git.savannah.gnu.org/cgit/m4.git/= tree/HACKING?h=3Dbranch-1.4">https://git.savannah.gnu.org/cgit/m4.git/tree/= HACKING?h=3Dbranch-1.4</a> almost covers it but not quite.<o:p></o:p></p> </div> <div> <p class=3D"MsoNormal"><o:p> </o:p></p> </div> <div> <p class=3D"MsoNormal">I would follow the guidance in that file wrt style a= nd such, and then send patches to the m4-patches<o:p></o:p></p> </div> <div> <p class=3D"MsoNormal">mailing list (<a href=3D"mailto:[email protected]">= [email protected]</a> <mailto:<a href=3D"mailto:[email protected]">m4-= [email protected]</a>>) using git-send-email.<o:p></o:p></p> </div> <div> <p class=3D"MsoNormal"><o:p> </o:p></p> </div> <div> <p class=3D"MsoNormal">Best,<o:p></o:p></p> </div> <div> <p class=3D"MsoNormal">sam<o:p></o:p></p> </div> <div> <p class=3D"MsoNormal"><o:p> </o:p></p> </div> </div> </body> </html> --_000_BN8PR15MB30607C058906F2F31C015E7598EE9BN8PR15MB3060namp_--