Re: Frozen state generation fails with returncode 0
Eric Blake <[email protected]>
| Newsgroups | gmane.comp.gnu.m4.patches,gmane.comp.gnu.m4.bugs |
|---|---|
| Message-ID | <[email protected]> |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 According to Eric Blake on 5/21/2008 9:51 PM: | | Thanks for the report. Which version of m4 was this against? I'm | guessing this was against a release tarball, rather than the current git | repository, since this area of code has changed in the meantime? It turns out that a prior change already fixed this: http://git.savannah.gnu.org/gitweb/?p=m4.git;a=commitdiff;h=910837e#patch7 This patch is in the beta 1.4.10b (and thus will be in 1.6), but did not get backported to 1.4.11. | | | | | Wouldn't it be consistent to also exit on open() failures, | | with this one-line patch or equivalent ? | | abort() is too strong - users should not get a core dump merely because | they requested a file that can't be opened. So I'll be applying this | instead: I'm still applying a portion of this change, since testing for this condition is worthwhile, but am no longer using the freeze.c change. If I decide that the 1.6 release is taking too long, I might get around to releasing 1.4.12, and this would be one of the patches I would backport. - -- Don't work too hard, make some time for fun as well! Eric Blake [email protected] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkg1Xy0ACgkQ84KuGfSFAYBxMQCgmrLJeJ22Ll0HCQ6BeHYH9gjI gQAAoIbrHtu9g9s6byog5OKa3Y+yEdR8 =ZXRO -----END PGP SIGNATURE-----