Re: use execute module in m4

"Gary V. Vaughan" <[email protected]>
Newsgroups gmane.comp.gnu.m4.patches
Message-ID <[email protected]>
Hi Eric,

2009/3/4 Eric Blake <[email protected]>:
> Here's the followup patches which switch to the pipe module for esyscmd,
> nuke code rendered dead now that gnulib takes care of separating signal
> from normal exit status, then adds ./configure --with-syscmd-shell to
> allow overriding the default choice of /bin/sh (or, on Solaris,
> /usr/xpg4/bin/sh).  I've tested this on several platforms, but won't push
> to savannah until I've ported it to branch-1.6 and master.  To test it
> now, you can:
>
> $ git pull git://repo.or.cz/m4/ericb.git branch-1.4
>
> Gary, I'd be particularly interested in seeing if this cleans up the
> testsuite failures you saw on AIX related to sysval (since I already made
> that assumption when writing the ChangeLog).

% automake --version
automake (GNU automake) 1.10.1
Copyright (C) 2008 Free Software Foundation, Inc.
License GPLv2+: GNU GPL version 2 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Tom Tromey <[email protected]>
       and Alexandre Duret-Lutz <[email protected]>.
% autoconf --version
autoconf (GNU Autoconf) 2.63
Copyright (C) 2008 Free Software Foundation, Inc.
License GPLv2+: GNU GPL version 2 or later
<http://gnu.org/licenses/old-licenses/gpl-2.0.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by David J. MacKenzie and Akim Demaille.
% cd ~/devel/gnulib--ericb--0
% git pull
Already up-to-date.
% git describe
v0.0-1834-g30163b1
% cd ~/devel/m4--ericb--1.4
% git pull
Already up-to-date.
% git describe
v1.4.12-34-g060b531
% GNULIB_TOOL=/home/gary/devel/gnulib--ericb--0/gnulib-tool ./bootstrap
...
% mkdir _build
% cd _build
% ../configure
...
% make dist
make: Warning: File `Makefile' has modification time 30 s in the future
{ test ! -d m4-1.4.12.34-060b5 || { find m4-1.4.12.34-060b5 -type d !
-perm -200 -exec chmod u+w {} ';' && rm -fr m4-1.4.12.34-060b5; }; }
test -d m4-1.4.12.34-060b5 || mkdir m4-1.4.12.34-060b5
cp: preserving permissions for `m4-1.4.12.34-060b5/README': Operation
not supported
make: *** [distdir] Error 1
% cp --version
cp (coreutils) 5.2.1
Written by Torbjorn Granlund, David MacKenzie, and Jim Meyering.

Copyright (C) 2004 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
% find . -name Makefile -exec sed -i -e 's,cp -p ,cp ,;s,cp -p,cp -,' {} \;
% make dist
...

After that very long preamble (so that you can check my bootstrap
sanity!), you'll
be pleased to hear that AIX now passes all tests in all releases I
have access to.

I am, however, encountering this error now on HPUX and Tru64:

make[2]: Entering directory `/opt/build/m4-1.4.12.34-060b5/checks'
rm -f ./*[0-9][0-9][0-9].*
cd . && AWK=nawk ./get-them ../doc/m4.texinfo
awk: There is a regular expression error.
        \{ \} imbalence
 The source line number is 99.
 The error context is
                  gsub("@{", "{", >>>  $0) <<< ;

...which is easy enough to work around by installing gnu awk, and using
'./configure AWK=gawk' for m4, although that wasn't necessary on the last
rounds of testing, and I don't believe I have ever had gawk in my path at
configure time (except on linux where it is installed by default) :-?

Anyway, nits aside, this build of m4 passes all tests on all our machines
except:

  i686-redhat-linuxe2.1-gcc2.96
  i686-redhat-linux9-gcc3.2.2
  i686-redhat-linux7.1-gcc2.96
  hppa2.0-hp-hpux10.20-cc10.32

(as reported previously)

Cheers,
    Gary
-- 
Email me:          [email protected]                        (\(\
Read my blog:      http://blog.azazil.net              ( o.O)
And my other blog: http://www.machaxor.net              (uu )o
...and my book:    http://sources.redhat.com/autobook  ("("_)
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.