Re: Long option for -W (--word-regexp) accepted without ENABLE_CHANGEWORD defined

On 02/05/2014 06:58 AM, Vitezslav Crhonek wrote:
> Hello,
> 
> small issue I've found today, here's the fix:
> 
> --- m4-1.4.17/src/m4.c.orig     2013-09-22 07:50:43.000000000 +0200
> +++ m4-1.4.17/src/m4.c  2014-02-05 14:49:06.706025544 +0100
> @@ -307,7 +307,9 @@
>    {"trace", required_argument, NULL, 't'},
>    {"traditional", no_argument, NULL, 'G'},
>    {"undefine", required_argument, NULL, 'U'},
> +#ifdef ENABLE_CHANGEWORD
>    {"word-regexp", required_argument, NULL, 'W'},
> +#endif

Indeed the correct fix.  The problem isn't completely bad, just a poor
error message:

$ m4 -W
m4: invalid option -- 'W'
Try `m4 --help' for more information.
$ m4 --word-regexp=
Try `m4 --help' for more information.

and with your patch:

$ src/m4 --word-regexp=
src/m4: unrecognized option '--word-regexp='
Try `src/m4 --help' for more information.


I added a changelog entry (the 'tiny change' marker explains we did not
need copyright papers) and pushed the patch.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

_______________________________________________
M4-patches mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/m4-patches

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJS8py5AAoJEKeha0olJ0NqvtcIAIWFLfIrp3IsFM9uUI3cmW/9
c7fwtJc6eUUthM13t3Q+xjZ871fDt1576eqVBwgNkRHdn6cM2i+qs6rwzPxg05vW
j7d+hi3TMaq2yUKRmt2UT+/wfq23+a4zueG4qMgIBNfD5vh5A1F4IAkPV1XlEDd4
poFTiHdtpkPVgt9LzIT9QgsvPxzsN/sW9cG76oqeINZJZ+ufrCE1GQAnAsGjiCf9
ewO3KqN8heg1AlpBRgN4UJRc7PyvKraVyP52ulHC+XEaVuSyFWzll9CxoPrP08mn
8B7lGmVm6MjPEoP9wVPEbdq7V5gO3iKNpt3R7UJtTonyed7CvGFiJRWmAlcw3aQ=
=DhDu
-----END PGP SIGNATURE-----