Re: [PATCH 2/2] libm4: support UNIXROOT on OS/2

Eric Blake <[email protected]> Tue, 09 Dec 2014 14:35:46 -0700

Newsgroups	gmane.comp.gnu.m4.patches
Organization	Red Hat, Inc.
Message-ID	<[email protected]>

On 12/09/2014 02:17 PM, Gary V. Vaughan wrote:

>>> +#if OS2
>>> +#  define UNIXROOT "/@unixroot"
>>> +#else
>>> +#  define UNIXROOT ""
>>> +#endif
>>> +
>>> void
>>> m4__include_init (m4 *context)
>>> {
>>> @@ -393,7 +399,7 @@ m4__include_init (m4 *context)
>>>       search_path_add (info, "", false);
>>>
>>>     /* Non-core modules installation directory. */
>>> -    search_path_add (info, PKGLIBDIR, false);
>>> +    search_path_add (info, UNIXROOT PKGLIBDIR, false);
>>>   }
>>>
>>> #ifdef DEBUG_INCL
> 
> This seems like papering over the cracks to me.
> 
> Wouldn't it be better to fix this for every project by patching the gnulib
> configmake module to set the appropriate prefix for all the configured
> directories?

Or even fix autoconf/automake so that PKGLIBDIR is defined with UNIXROOT
to begin with.  Ideally, PKGLIBDIR should be the right string.

> If we fix just PKGLIBDIR, for just M4, you'll have a zillion tiny patches
> to discover, write and shepherp through their individual projects otherwise.

I agree, the proposed patch is the wrong approach to the fix.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

_______________________________________________
M4-patches mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/m4-patches

signature.asc (application/pgp-signature, 539 B)