Re: [PATCH] tests: Fix 198.sysval
[email protected] Wed, 2 Jun 2021 05:01:36 -0500
| Newsgroups | gmane.comp.gnu.m4.bugs,gmane.comp.gnu.m4.patches |
|---|---|
| Organization | Snaggled Works |
| Message-ID | <[email protected]> |
On 6/1/21 8:16 AM, Eric Blake wrote:
> In my attempt to avoid test failures on Haiku, I caused test failures
> on platforms where sh is noisy when reporting a killed sub-process.
>
> * doc/m4.texi (Sysval): Avoid stderr noise during test.
> Fixes: 17011ea76a (tests: Skip signal detection on Haiku)
> Fixes: https://lists.gnu.org/archive/html/bug-m4/2021-05/msg00029.html
> ---
> doc/m4.texi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/doc/m4.texi b/doc/m4.texi
> index 247f2be5..3b833b2a 100644
> --- a/doc/m4.texi
> +++ b/doc/m4.texi
> @@ -6756,7 +6756,7 @@ Sysval
> ')m4exit(`77')')dnl
> changequote(`[', `]')
> @result{}
> -syscmd([/bin/sh -c 'kill -9 $$'; st=$?;
> +syscmd([@{ /bin/sh -c 'kill -9 $$'; @} 2>/dev/null; st=$?;
> test $st = 137 || test $st = 265])
> @result{}
> ifelse(sysval, [0], , [errprint([ skipping: shell does not send signal 9
Confirming that patching the 1.4.19 tarball with commits a1354086 and
cd7f4d15 makes 198.sysval pass on macOS. Thank you,
```
Checking ./197.sysval
Checking ./198.sysval
Checking ./199.mkstemp
```
Hanspeter