Re: [PATCH] sigsegv: Fix build on ppc/musl

Sam <[email protected]> Sun, 13 Mar 2022 16:14:41 +0000
Newsgroups gmane.comp.gnu.m4.patches,gmane.comp.lib.gnulib.bugs
Message-ID <[email protected]>
--===============1757429474871372395==
Content-Type: multipart/signed;
	boundary="Apple-Mail=_AAF39986-82FA-435A-8E9C-D4C4B3E99937";
	protocol="application/pgp-signature";
	micalg=pgp-sha512


--Apple-Mail=_AAF39986-82FA-435A-8E9C-D4C4B3E99937
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8



> On 13 Mar 2022, at 14:17, Bruno Haible <[email protected]> wrote:
>=20
> Eric Blake wrote:
>> On Wed, Mar 09, 2022 at 11:37:14PM -0800, Khem Raj wrote:
>>> mcontext is not a standard layout so glibc and musl differ sadly.
>>>=20
>>> Fixes
>>> ../../m4-1.4.19/lib/sigsegv.c: In function 'sigsegv_handler':        =
                                                                         =
                                              =
../../m4-1.4.19/lib/sigsegv.c:223:75: error: 'mcontext_t' has no member =
named 'uc_regs'; did you mean 'gregs'?                                   =
                                             223 | #    define =
SIGSEGV_FAULT_STACKPOINTER  ((ucontext_t *) =
ucp)->uc_mcontext.uc_regs->gregs[1]                                      =
                                                         |               =
                                                            ^~~~~~~
>>=20
>> Thanks for the report.  As this file comes from gnulib, the fix needs
>> to go there first.
>=20
> Thanks for the report. I'm adding this patch to GNU libsigsegv:
> =
https://git.savannah.gnu.org/gitweb/?p=3Dlibsigsegv.git;a=3Dcommitdiff;h=3D=
a6ff69873110c0a8ba6f7fd90532dbc11224828c
>=20
> and then this (derived) patch to Gnulib.
>=20
> I couldn't verify that it works, since there is no Linux distro that =
is based
> on musl libc and is ported to Linux/powerpc (32-bit).

There's at least Gentoo, Ad=C3=A9lie, and at least for now, Void.

Thanks for adding the patch and thanks to Khem for reporting it.

Best,
sam

--Apple-Mail=_AAF39986-82FA-435A-8E9C-D4C4B3E99937
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQGTBAEBCgB9FiEEYOpPv/uDUzOcqtTy9JIoEO6gSDsFAmIuGHFfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDYw
RUE0RkJGRkI4MzUzMzM5Q0FBRDRGMkY0OTIyODEwRUVBMDQ4M0IACgkQ9JIoEO6g
SDtYIAgAgpvQtrxr+kZrgkdV9deUZcrOpvntJkef61cXojV/ZFyjnJ2nTt4N/H2P
mKzyyW7QvlTMRu47G8iINk/jdwk6kEszZ44X5DI1wiP+wgFOm60DVhiKWeI1Pn8R
hq3AKW6VJ4T9tS0/niwTjWg0Rc42aF/0rvrTZ4M/Yf0Cnp/d5sCUF770se1ewc5G
hHL08Tse3qBB6kS4CkGrtiJ9I5ScPkhBuLJAUzn7/o8SmkekH1ApolCSa6d8gSzZ
ajOddEMZJVjXSZwM68O2r1VjnTXLo9B+3cS+FxF74+1NO3CjzBJFoJJPMLjADwHH
wNunF9prHUS6Xb1bowzF+4pTMJf2Zg==
=dJwS
-----END PGP SIGNATURE-----

--Apple-Mail=_AAF39986-82FA-435A-8E9C-D4C4B3E99937--


--===============1757429474871372395==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTTQtcGF0Y2hl
cyBtYWlsaW5nIGxpc3QKTTQtcGF0Y2hlc0BnbnUub3JnCmh0dHBzOi8vbGlzdHMuZ251Lm9yZy9t
YWlsbWFuL2xpc3RpbmZvL200LXBhdGNoZXMK

--===============1757429474871372395==--