Re: testsuite: distributed depending on non-distributed

Eric Blake <[email protected]>
Newsgroups gmane.comp.gnu.m4.patches
Message-ID <[email protected]>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Ralf Wildenhues on 9/13/2006 8:43 PM:
> Thanks, but now I get `make check' failures for tests 42-47:

D'oh - they were using AT_CHECK directly instead of AT_CHECK_M4, which did
the filtering.  I'll get it yet...

2006-09-13  Eric Blake  <[email protected]>

	* tests/modules.at (AT_CHECK_M4_MODTEST): Use AT_CHECK_M4, for
	stderr filtering.

Index: tests/modules.at
===================================================================
RCS file: /sources/m4/m4/tests/modules.at,v
retrieving revision 1.21
diff -u -p -r1.21 modules.at
- --- tests/modules.at    14 Sep 2006 00:37:26 -0000      1.21
+++ tests/modules.at    14 Sep 2006 03:36:07 -0000
@@ -89,7 +89,13 @@ test
 Dumpdef: dumpdef(`test').
 ]])

- -AT_CHECK([$2 m4 -m load -d $3 input.m4], [0],
+dnl Fortunately, all tests within AT_SETUP are in the same subshell, so
+dnl setting the environment now will impact the AT_CHECK_M4, but not
+dnl carry over to the next AT_SETUP.
+m4_ifval([$2], [$2
+export m4_substr([$2], [0], m4_index([$2], [=]))])
+
+AT_CHECK_M4([-m load $3 input.m4], [0],
 [[
 Test module called.
 Dumpdef: .

- --
Life is short - so eat dessert first!

Eric Blake             [email protected]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFCM5484KuGfSFAYARAlnBAKC0EL2rgh5FJFcNTZl8JaxjiSmzVACgwOBV
nPzkA758hRfKiGBepv6eZ64=
=NRYr
-----END PGP SIGNATURE-----
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.