Re: [GNU M4 1.9a] testsuite: 52 59 60 61 62 failed
Eric Blake <[email protected]>
| Newsgroups | gmane.comp.gnu.m4.patches |
|---|---|
| Message-ID | <[email protected]> |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 According to Eric Blake on 10/14/2006 9:35 AM: > > I'm not sure if it would be cleaner to see just: > $ m4 - - <&- > m4: error reading file `stdin' On the other hand, $ cat - bad - <&- cat: -: Bad file descriptor cat: bad: No such file or directory cat: -: Bad file descriptor cat: closing standard input: Bad file descriptor So there's precedence in reporting the read errors as they happen, then the close error at the end. With that, here's the testsuite patch. 2006-10-14 Eric Blake <[email protected]> * tests/others.at (stdin closed): Update to match previous patch. Index: tests/others.at =================================================================== RCS file: /sources/m4/m4/tests/others.at,v retrieving revision 1.24 diff -u -p -r1.24 others.at - --- tests/others.at 10 Oct 2006 12:47:23 -0000 1.24 +++ tests/others.at 14 Oct 2006 15:54:19 -0000 @@ -435,17 +435,20 @@ AT_CHECK_M4([in.m4], [0], [[hello world dnl error when stdin must be read AT_CHECK_M4([], [1], [], [[m4:stdin:1: error reading file `stdin' +m4: error closing stdin: Bad file descriptor ]], [-]) dnl error when stdin must be read AT_CHECK_M4([-], [1], [], [[m4:stdin:1: error reading file `stdin' +m4: error closing stdin: Bad file descriptor ]], [-]) dnl error once per command-line attempt to read stdin AT_CHECK_M4([- in.m4 -], [1], [[hello world ]], [[m4:stdin:1: error reading file `stdin' m4:stdin:1: error reading file `stdin' +m4: error closing stdin: Bad file descriptor ]], [-]) dnl command line and trace file must not collide with stdin @@ -473,6 +476,7 @@ divert`'world ]]) AT_CHECK_M4([in.m4 - in2.m4], [1], [[hello world ]], [[m4:stdin:1: error reading file `stdin' +m4: error closing stdin: Bad file descriptor ]], [-]) AT_CLEANUP - -- Life is short - so eat dessert first! Eric Blake [email protected] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.1 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFFMQhb84KuGfSFAYARAqgqAKCMENn/Ty0ERydx9uU9GzhM9Lb0SACgxg02 kC17BcDQt7qUeYd/ees5h4Q= =3tVf -----END PGP SIGNATURE-----