Re: FYI: 28-gary-sanitise-header-includes

Hi Eric,

Hi Eric,

Thanks for the patch.  I'll get back to mine next week, but first a
few nits...

On 8 Apr 2007, at 06:06, Eric Blake wrote:
> 2007-04-07  Eric Blake  <[email protected]>
>
> 	Include <config.h> first in all C files, and not in headers.

Add a note to HACKING to remind us (and future contributors) of this?

> 	Fixes regression for --disable-assert builds from 2007-04-02.

Add a test that does a VPATH --disable-assert configure and make to
prevent a similar regression with future patches?

> 	* src/m4.h (includes): Don't include config.h here.
> 	* m4/m4private.h (includes): Likewise.
> 	* m4/builtin.c: Include config.h before anything else.
> 	* m4/debug.c: Likewise.
> 	* m4/hash.c: Likewise.
> 	* m4/input.c: Likewise.
> 	* m4/m4.c: Likewise.
> 	* m4/macro.c: Likewise.
> 	* m4/module.c: Likewise.
> 	* m4/symtab.c: Likewise.
> 	* m4/syntax.c: Likewise.
> 	* m4/utility.c: Likewise.
> 	* src/freeze.c: Likewise.
> 	* src/stackovf.c: Likewise.

By the way, using inline GPG signatures like this *does* fix the
patch corruption problem, but now means (arguably worse!) that the
patch itself is no longer signed... (bad guys: please cover your
ears for the next couple of seconds) someone could take your signed
body, and submit an entirely different patch in your name in a
year or two hoping a future maintainer will commit it...

Cheers,
	Gary
-- 
   ())_.              Email me: [email protected]
   ( '/           Read my blog: http://blog.azazil.net
   / )=         ...and my book: http://sources.redhat.com/autobook
`(_~)_ Join my AGLOCO Network: http://www.agloco.com/r/BBBS7912

_______________________________________________
M4-patches mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/m4-patches