Re: use build-aux

Eric Blake <[email protected]>
Newsgroups gmane.comp.gnu.m4.patches
Message-ID <[email protected]>
According to Ralf Wildenhues on 11/6/2007 4:31 AM:
> You need to ensure build-aux/mkstamp exists at the end of the bootstrap.
> You could copy it from ltdl/config/.

Or is there a better way to make libtool share build-aux, rather than
creating its own subdirectory?  Perhaps using the libtoolize
--nonrecursive or --recursive option?

> 
> FWIW I think libtool should move to using build-aux only after moving to
> git, thus after 2.2.

Was this sentence meant in the context of using build-aux within the
libtool source tree, or the context of making libtoolize use build-aux of
the project where libtool is copied to?

> 
> BTW, HEAD m4 needs the same bash redirected compound command workaround
> for package.m4 as Autoconf.

Thanks.  Applying:

From: Eric Blake <[email protected]>
Date: Tue, 6 Nov 2007 06:14:37 -0700
Subject: [PATCH] * Makefile.am (tests/package.m4): Work around bash bug.

Reported by Ralf Wildenhues.

Signed-off-by: Eric Blake <[email protected]>
---
 ChangeLog   |    5 +++++
 Makefile.am |    4 +++-
 2 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 1526687..0a986c6 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2007-11-06  Eric Blake  <[email protected]>
+
+	* Makefile.am (tests/package.m4): Work around bash bug.
+	Reported by Ralf Wildenhues.
+
 2007-11-05  Eric Blake  <[email protected]>

 	For consistency with other GNU projects, use build-aux directory.
diff --git a/Makefile.am b/Makefile.am
index a2e67d9..20fc3c5 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -394,8 +394,10 @@ $(TESTSUITE): tests/package.m4 $(TESTSUITE_AT)
 	$(AUTOTEST) -I '$(srcdir)/tests' -o [email protected] [email protected]
 	mv [email protected] $@

+# The leading :; works around a bug in {}>f in some bash versions.
 $(srcdir)/tests/package.m4: configure.ac
-	{					\
+	:; \
+	{ \
 	  echo '# Signature of the current package.'; \
 	  echo 'm4_define([AT_PACKAGE_NAME],      [@PACKAGE_NAME@])'; \
 	  echo 'm4_define([AT_PACKAGE_TARNAME],   [@PACKAGE_TARNAME@])'; \
-- 
1.5.3.2

-- 
Don't work too hard, make some time for fun as well!

Eric Blake             [email protected]
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.