Re: [PATCH] Fix memory reuse bug in comsat

"Sergey Poznyakoff" <[email protected]> Wed, 06 May 2026 15:33:50 +0200
Newsgroups gmane.comp.gnu.mailutils.bugs
Organization GNU.org.ua
Message-ID <[email protected]>
Hi Alyssa,

Thanks for reporting.

> I maintained consistency with the other surrounding code by not
> checking for allocation failure

That's not so. The code mostly uses memory allocating functions with
error checking (mu_alloc and the like), which are warranted to return
non-NULL values. In a few cases where standard memory allocation
functions are used, their return is always checked.

> and only freeing allocated memory in the happy path.

Yes, there's no use freeing anything before exit.

Fixed in commit 6e038f04d5.

Regards,
Sergey