Re: Minor patch to correct buffer overrun
Eli Zaretskii <[email protected]>
| Newsgroups | gmane.comp.gnu.make.windows |
|---|---|
| Message-ID | <[email protected]> |
> From: Paul Smith <[email protected]> > Date: Mon, 16 Aug 2010 15:04:51 -0400 > Cc: [email protected] > > On Mon, 2010-08-16 at 11:13 -0400, Chris Sutcliffe wrote: > > No, I didn't explain things well. MAX_PATH on windows should be 259. > > Hm. I think the entire MAXPATHLEN thing is something that needs to be > cleaned up. > > I think a better idea would be to use the POSIX standard value of > PATH_MAX, everywhere in the code. > > Then on systems that don't support PATH_MAX we can try to find an > appropriate value elsewhere, such as MAXPATHLEN or whatever, but that > would be all contained in one place (make.h I expect) then a consistent > value would be used everywhere. FWIW, both MinGW and DJGPP (a.k.a. DOS) builds support PATH_MAX in their respective <limits.h> header files. I agree with using PATH_MAX, because it is more standard.