Re: Minor patch to correct buffer overrun

Eli Zaretskii <[email protected]>
Newsgroups gmane.comp.gnu.make.windows
Message-ID <[email protected]>
> Date: Thu, 26 Aug 2010 12:08:43 -0400
> From: Chris Sutcliffe <[email protected]>
> Cc: [email protected], [email protected]
> 
> +#if defined(HAVE_DOS_PATHS)
> +# undef PATH_SEPARATOR_CHAR
> +# define PATH_SEPARATOR_CHAR ';'
> +#elif defined(VMS)
> +# undef PATH_SEPARATOR_CHAR
> +# define PATH_SEPARATOR_CHAR ','
> +#else
> +# ifndef PATH_SEPARATOR_CHAR
> +#   define PATH_SEPARATOR_CHAR ':'
>  # endif
>  #endif

HAVE_DOS_PATHS is supported in the Cygwin build as well, and there
PATH_SEPARATOR_CHAR must stay ':'.  So please modify your patch to
exclude Cygwin from its effect, and then I'll agree to its
HAVE_DOS_PATHS part.  I leave the rest to VMS expert and to Paul.

Also, I think it'd be good to add a comment there explaining why we
are overriding the results of the configure scripts.

Thanks.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.