Re: Minor patch to correct buffer overrun
Paul Smith <[email protected]>
| Newsgroups | gmane.comp.gnu.make.windows |
|---|---|
| Organization | GNU's Not Unix! |
| Message-ID | <1283032496.3031.7.camel@homebase> |
On Fri, 2010-08-27 at 09:41 +0300, Eli Zaretskii wrote: > > Date: Thu, 26 Aug 2010 21:53:11 -0400 > > From: Chris Sutcliffe <[email protected]> > > CC: [email protected], [email protected] > > > Fine with me. If Paul doesn't object, I will commit this upstream. > > Thanks. The patch is OK if the Windows folks like it. I still don't see how this solves the core dump problem though. What if someone creates a vpath pathname that is really really long and doesn't contain any separators, or uses the wrong separator again (e.g., using : where ; is expected)? Even if we use the wrong separator, or just one really long pathname that's too long for the underlying system, make absolutely should not, ever, dump core. -- ------------------------------------------------------------------------------- Paul D. Smith <[email protected]> Find some GNU make tips at: http://www.gnu.org http://make.mad-scientist.net "Please remain calm...I may be mad, but I am a professional." --Mad Scientist