Re: Bug in the `sbpr' command of mixvm

Hi,

On Thu, Sep 23 2010, rrl wrote:

> Hi,
>
> There's a problem with the command `sbpr' that set a conditional
> breakpoint on register change.  For example, `sbpr I2' should set a
> breakpoint when the value in rI2 changes but the breakpoint will be
> set when the value of rI1 changes instead.  Here's a patch that fixes
> the problem:
>
> --- mixlib/xmix_vm_handlers.c.orig	2005-09-20 22:43:13.000000000 +0300
> +++ mixlib/xmix_vm_handlers.c	2010-09-23 10:28:32.000000000 +0300
> @@ -1089,7 +1089,7 @@
>  	  {
>  	    int i = arg[1] - '1';
>  	    if (i >= 0 && i < 6)
> -	      pred = MIX_PRED_REG_I1 - 1 + i;
> +	      pred = MIX_PRED_REG_I1 + i;
>  	  }
>        }
>        break;

Good catch! Thanks a lot for the patch... i'll apply it as soon as i
come back from a short vacation!

Cheers,
jao