Can someone please help me to understand this commit?
Keith Marshall <[email protected]> Tue, 14 Jun 2016 15:00:27 +0100
| Newsgroups | gmane.comp.gnu.mingw.devel |
|---|---|
| Organization | MinGW Project |
| Message-ID | <[email protected]> |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Guys, Looking at Cesar's clone of our original CVS, I'm utterly confused by: https://sourceforge.net/u/cstrauss/mingwrt/ci/56e6189f267527e4dd710d55a16de39f7bf21c4a/ It appears to have been committed, originally, by Earnie, and I have too issues with it: 1) The declaration of _locale_t surely belongs in <locale.h>, not in <_mingw.h>. Furthermore, as a reference to an opaque type, we could just as well define it as a pointer to void, (although a pointer to a single incomplete structure type may make sense); I can certainly see absolutely no advantage in defining it as an aggregate of *two* other opaque structural types. 2) I am utterly mystified by the changes to mingwex/tsearch.c, (which appear to have accidentally have crept into the commit). AFAICT, the original code, (which has come from NetBSD), works just fine; I have no idea what issue these changes were intended to resolve, but once again AFAICT, they should have absolutely no functional effect whatsoever. What am I missing? - -- Regards, Keith. Public key available from keys.gnupg.net Key fingerprint: C19E C018 1547 DE50 E1D4 8F53 C0AD 36C6 347E 5A3F -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) iQIcBAEBAgAGBQJXYA37AAoJEMCtNsY0flo/nCAP/13t8lgVFBMCrZ4opkNdoZBm Iloxz71cgeUjf8QdO0FGWxoknIV2vlhu9FjR4KlJ4yzQKpZfj+YGHrWplD05Oav1 dw+/R5qN3tz2reiZIDwx/9X0uFwCOQtZ90/mKuER0wC/BgEbGpOt78+jgrvbBc42 xa5f7T9bK0ImA7CDFy1sNhvSeteeZ+49HvYEZqc5PLJnnwSiz+z1Yf3fULu/BgJL eN6Leu570VsQARFajHgfpqfF1/KMlGxR2JBOTpa7V8W5loCClnOzk/zZAxtmmXQW N6CDA3iq71MJ2KQXNCEnGG9A6VnoidkuwQIpU9C2ALtnpqfkoW92W7E/tdQU1aW5 YVNJawnD5yHmfFmBzUeJk0cA7CXWBncURYv24KCj8cX8PjtENpJGil1dnea+tGgh m87/mcPqtKTshe84P30ZIwqhnJ75pfnUp7ORUC8Val/eLGr7b1yVswyzWqBYhQmk Ct7rx4xllPh23ORFKSEZ8KvuzRec7YlnOJKzEomwkkB746zTj4uo6PWTUOrnYg3O tU/dnSA7n1+LpuO6BF7hEy+X7bV+6CsVx8oip0vctW4skbvES8nENt1Ibc7m+j8Z skf2ODjs+Zih/KwDFCyxWhfdmQUf0Y7XpoaD/bo3h00i41cE83X+98RCU7S7Isq0 Ufw5Fgt468HoPejY0s71 =lVWf -----END PGP SIGNATURE----- ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e