Re: Can someone please help me to understand this commit?

On 6/14/2016 10:00 AM, Keith Marshall wrote:
> Guys,
> 
> Looking at Cesar's clone of our original CVS, I'm utterly confused by:
> https://sourceforge.net/u/cstrauss/mingwrt/ci/56e6189f267527e4dd710d55a16de39f7bf21c4a/
> 
> It appears to have been committed, originally, by Earnie, and I have
> too issues with it:
> 
> 1) The declaration of _locale_t surely belongs in <locale.h>, not in
> <_mingw.h>.  Furthermore, as a reference to an opaque type, we could
> just as well define it as a pointer to void, (although a pointer to a
> single incomplete structure type may make sense); I can certainly see
> absolutely no advantage in defining it as an aggregate of *two* other
> opaque structural types.
> 
> 2) I am utterly mystified by the changes to mingwex/tsearch.c, (which
> appear to have accidentally have crept into the commit).  AFAICT, the
> original code, (which has come from NetBSD), works just fine; I have
> no idea what issue these changes were intended to resolve, but once
> again AFAICT, they should have absolutely no functional effect whatsoever.
> 
> What am I missing?
> 

I don't have an answer; too long ago and I've not been thinking MinGW
for a while.  The tsearch.c change does to appear to have been
accidentally entered since the change isn't documented.

-- 
Earnie

------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are 
consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
J-Flow, sFlow and other flows. Make informed decisions using capacity planning
reports. http://pubads.g.doubleclick.net/gampad/clk?id=1444514421&iu=/41014381