Re: RFC: <excpt.h>: __try1/__except1 are broken; are they worth fixing?
Keith Marshall <[email protected]> Sun, 26 Jun 2016 19:14:39 +0100
| Newsgroups | gmane.comp.gnu.mingw.devel |
|---|---|
| Organization | MinGW Project |
| Message-ID | <[email protected]> |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 21/06/16 16:37, Earnie wrote:
> It's been too long for me to remember what I was thinking about the
> change but I'm guessing that it never worked as intended.
I suspect that you were simply trying to provide an element of 64-bit
readiness, without any consideration of whether, or not, the original
32-bit implementation actually worked; consequently, you've adapted
broken 32-bit code, to create an equally broken 64-bit derivative.
Admittedly, I might have done the same, if I hadn't searched the bug
tracker, for any potentially related issue, and reviewed those which I
found; in particular, the one I mentioned earlier in the thread, which
was, erroneously IMO, closed as invalid.
The good news is that it may not be as difficult to fix as I had first
thought; indeed, I have a working adaptation which may resolve one of
my own FIXMEs, (in mingwex/glob.c), so it's likely worth pursuing. I
do have one reservation: the current __try1(exception_handler)
followed by free-standing __except1 semantics seems rather
back-to-front to me. Surely, __try2 { action code }
__except2(handler) { remedial code } seems more logical?
- --
Regards,
Keith.
Public key available from keys.gnupg.net
Key fingerprint: C19E C018 1547 DE50 E1D4 8F53 C0AD 36C6 347E 5A3F
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (GNU/Linux)
iQIcBAEBAgAGBQJXcBuPAAoJEMCtNsY0flo/KLwQAMOmPsrI2v1FEFW3KnaEXhgw
9PCYMp7lyzHldRqTFxtRvRErZ7fUhhQRRqkoR/c9dyN0DG34orZ/bQjaMYa0esb5
AhEfN8rqcPReod7VG8QzOA0fq/llUOkXng5ngcWAI81asmc6qp8uPiSHcc67P6a3
8rL7h757aJ2aG2+MEboXjwKLOYELWRFq+Nxd/golDjBxEH8g/d3mcKBDvlaSn8b/
HwBU6fuG1j3CzsewXCOk/nko6Vvt+K8MoRGyWjKT5vxGmh0BQEop5bCjMPqcru5U
/jyLBzMa2HYYIB2rFFRPFnlD748VLagZRN/krXczR+I3lOW9gW890dDlvdwQrl4q
RQw9o09tT2Q6xpr75+YslBpUg+CciXrfzk45C0SYIjedY0p+S8RPO07E+kookm9c
8cklnalaIpequc7VN8/J1CbRbsYB55De1Q+FxbhESaz2LA7hGKX1zdf9e0lkkTec
tB17dBHA6zIhpjcHWrN1wbDrubVlvnd+njjXS/u5ESIl+UoiGlXOLezA8nX2NGRq
6OQc79mfwjmVxKkqI/+Pz2kwVV6suGm7a8QjHqWzKT7I6a7T/hL+Cxvevic2XDdN
R/tfMupKT1mrqzljgrlx+N0astxpoJAgisg0V+FnqsvnWoWcOdOUIQsmUloZ1Exe
inkTkzR7CpD2lJTdjgaz
=j7dE
-----END PGP SIGNATURE-----
------------------------------------------------------------------------------
Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape