Re: [PATCH] Export symbols when compiling a C runtime library

lør, 2002-06-15 kl. 07:10 skrev Danny Smith:

> ===snip==
> >  #ifdef __MSVCRT__
> >  __int64  _filelengthi64(int);
> > -long _findfirsti64(const char*, struct _finddatai64_t*);
> > -int _findnexti64(long, struct _finddatai64_t*);
> > +int _findfirsti64(const char*, struct _finddatai64_t*);
> > +int _findnexti64(int, struct _finddatai64_t*);
> Are you sure about this.  My doc's say current prototypes are correct.

That will teach me to look in the right places ;o)

> > +++ include/string.h 15 Jun 2002 00:44:00 -0000
> > @@ -94,9 +94,9 @@
> >  /*
> >   * Multi-byte character functions
> >   */
> > -unsigned char* _mbschr (unsigned char*, unsigned char*);
> > +unsigned char* _mbschr (const unsigned char*, unsigned int);
> >  unsigned char* _mbsncat (unsigned char*, const unsigned char*,
> size_t);
> > -unsigned char* _mbstok (unsigned char*, unsigned char*);
> > +unsigned char* _mbstok (unsigned char*, const unsigned char*);
> 
> Actually these don't belong here at all but in mbstring.h or mbctype

Actually they were already there. The second patch will remove them from
string.h.

> The rest look okay. I'm not sure about the __MINGW_IMPORT changes
> though.

dllexport is not strictly needed, but extern is and they can't be marked
dllimport when building a runtime because then I get "undefined
references to _imp__<some-exported-symbol>.

Casper Hornstrup



_______________________________________________________________

Don't miss the 2002 Sprint PCS Application Developer's Conference
August 25-28 in Las Vegas - http://devcon.sprintpcs.com/adp/index.cfm?source=osdntextlink