Re: PATCH - add S_IRGRP etc to stat.h

----- Original Message -----
From: "Earnie Boyd" <earnie_boyd-/[email protected]>
To: <danglassey-XZoyATsUNX5Wk0Htik3J/[email protected]>
Cc: <[email protected]>
Sent: Monday, 17 June 2002 02:44
Subject: Re: [MinGW-patches] PATCH - add S_IRGRP etc to stat.h


> Hey Danny Smith,
>
> What's your opinion on this patch?
>
> I first thought that no it shouldn't go but then I went looking for
> S_IXUSR and that's not MS standard either, only there for portability.
> Given that, I think we should accept this patch.  I also think we need
> to wrap them all in a filter guard to not define them if the guard is
> defined just for the "minimalists".
>

Above sounds OK to me.  The macros look harmless, but the harmless ones
have a habit of biting later.
How about
#if ! (defined  (__NO_POSIX_SRC)  || defined (__STRICT_ANSI__) )

Other defines (like the M_PI et al math constants that some want in
math.h) could be guarded by
#if ! (defined  (__NO_XOPEN_SRC)  || defined (__STRICT_ANSI__) )

Danny

> Earnie.
>
> Daniel Glassey wrote:
> >
> > This patch is to include/sys/stat.h in mingw-runtime 2.0
> >
> > It is would be very useful for it being in for building AbiWord with
> > mingw (the alternative is to patch the AbiWord source)
> >
> > Regards,
> > Daniel
> >
>
  ----------------------------------------------------------------------
--
> > --- stat.h      Thu Jun 13 11:47:25 2002
> > +++ stat2.h     Thu Jun 13 11:47:10 2002
> > @@ -60,6 +60,9 @@
> >  #define        _S_IXUSR        _S_IEXEC
> >  #define        _S_IWUSR        _S_IWRITE
> >  #define        _S_IRUSR        _S_IREAD
> > +#define        _S_IXGRP        _S_IEXEC
> > +#define        _S_IWGRP        _S_IWRITE
> > +#define        _S_IRGRP        _S_IREAD
> >
> >  #define        _S_ISDIR(m)     (((m) & _S_IFMT) == _S_IFDIR)
> >  #define        _S_ISFIFO(m)    (((m) & _S_IFMT) == _S_IFIFO)
> > @@ -82,6 +85,9 @@
> >  #define        S_IXUSR         _S_IXUSR
> >  #define        S_IWUSR         _S_IWUSR
> >  #define        S_IRUSR         _S_IRUSR
> > +#define        S_IXGRP         _S_IXGRP
> > +#define        S_IWGRP         _S_IWGRP
> > +#define        S_IRGRP         _S_IRGRP
> >
> >  #define        S_ISDIR(m)      (((m) & S_IFMT) == S_IFDIR)
> >  #define        S_ISFIFO(m)     (((m) & S_IFMT) == S_IFIFO)
>
> _______________________________________________________________
>
> Sponsored by:
> ThinkGeek at http://www.ThinkGeek.com/
> _______________________________________________
> MinGW-patches mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/mingw-patches



_______________________________________________________________

Sponsored by:
ThinkGeek at http://www.ThinkGeek.com/