Re: [PATCH] Export symbols when compiling a C runtime library

----- Original Message -----
From: "Casper Hornstrup" <[email protected]>
To: <[email protected]>
Sent: Saturday, 15 June 2002 13:09
Subject: [MinGW-patches] [PATCH] Export symbols when compiling a C
runtime library


> This patch adds and corrects some definitions in the MinGW runtime.
> The patch also makes it possible to build a C runtime library with
these
> headers when _CRT_ is defined. If _CRT_ is defined, __MINGW_IMPORT
will
> mark symbols as dllexport instead of dllimport. I'm not sure if the
note
> applies to dllexport also.
>
==snip===

> Index: include/io.h
> ===================================================================
> RCS file: /cvsroot/mingw/runtime/include/io.h,v
> retrieving revision 1.4
> diff -u -r1.4 io.h
> --- include/io.h 29 Nov 2001 04:26:33 -0000 1.4
> +++ include/io.h 15 Jun 2002 00:43:59 -0000

===snip==
>  #ifdef __MSVCRT__
>  __int64  _filelengthi64(int);
> -long _findfirsti64(const char*, struct _finddatai64_t*);
> -int _findnexti64(long, struct _finddatai64_t*);
> +int _findfirsti64(const char*, struct _finddatai64_t*);
> +int _findnexti64(int, struct _finddatai64_t*);
Are you sure about this.  My doc's say current prototypes are correct.

==snip==


> -long _get_osfhandle (int);
> +int _get_osfhandle (int);
==snip==
>
> -int _open_osfhandle (long, int);
> +int _open_osfhandle (int, int);
 Again my docs say current prototype is correct

==snip===

> -long _wfindfirst(wchar_t*, struct _wfinddata_t*);
> -int _wfindnext(long, struct _wfinddata_t *);
> +int _wfindfirst(const wchar_t*, struct _wfinddata_t*);
> +int _wfindnext(int, struct _wfinddata_t *);

ditto


> -long  _wfindfirsti64(const wchar_t*, struct _wfinddatai64_t*);
> -int  _wfindnexti64(long, struct _wfinddatai64_t*);
> +int  _wfindfirsti64(const wchar_t*, struct _wfinddatai64_t*);
> +int  _wfindnexti64(int, struct _wfinddatai64_t*);

ditto.


===snip==

> Index: include/string.h
> ===================================================================
> RCS file: /cvsroot/mingw/runtime/include/string.h,v
> retrieving revision 1.3
> diff -u -r1.3 string.h
> --- include/string.h 29 Nov 2001 04:26:33 -0000 1.3
> +++ include/string.h 15 Jun 2002 00:44:00 -0000
> @@ -94,9 +94,9 @@
>  /*
>   * Multi-byte character functions
>   */
> -unsigned char* _mbschr (unsigned char*, unsigned char*);
> +unsigned char* _mbschr (const unsigned char*, unsigned int);
>  unsigned char* _mbsncat (unsigned char*, const unsigned char*,
size_t);
> -unsigned char* _mbstok (unsigned char*, unsigned char*);
> +unsigned char* _mbstok (unsigned char*, const unsigned char*);

Actually these don't belong here at all but in mbstring.h or mbctype




The rest look okay. I'm not sure about the __MINGW_IMPORT changes
though.

Danny
>
>
> _______________________________________________________________
>
> Don't miss the 2002 Sprint PCS Application Developer's Conference
> August 25-28 in Las Vegas -
http://devcon.sprintpcs.com/adp/index.cfm?source=osdntextlink
>
> _______________________________________________
> MinGW-patches mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/mingw-patches



_______________________________________________________________

Don't miss the 2002 Sprint PCS Application Developer's Conference
August 25-28 in Las Vegas - http://devcon.sprintpcs.com/adp/index.cfm?source=osdntextlink