[bug #45833] support load/save of classdef objects
foreverallama <[email protected]>
| Newsgroups | gmane.comp.gnu.octave.bugs |
|---|---|
| Message-ID | <[email protected]> |
Please use the bug tracker to post updates to a bug report. The mailing list is intended as a read-only notification stream. Info posted to this mailing list address won't appear in the tracker database where it is most useful.
Follow-up Comment #98, bug #45833 (group octave):
Looks good to me, thanks!
I'd like to add that I made a couple of small changes to "ls-mat-subsys.cc" in
the patch submitted in bug #67964 that I think would be useful to include
before the release as well. These changes are required for supporting
different subsystem versions within the MAT-file. The full patch also reverted
the changes in commit 93a820323d2c so I'm sharing a stripped patch here
instead with the following changes to "ls-mat-subsys.cc":
* Support for filewrapper versions 2 to 4
* Return raw metadata for case obj_id = 0
* Fix: Add early return when dynamic property metadata is non-existent
I also thought of adding an exception class to throw/catch specific errors
(for e.g.. unsupported version) instead of erroring out. Will try to submit a
patch for that tomorrow.
(file #58224)
_______________________________________________________
Additional Item Attachment:
Name: bug45833-filewrapper-versions.patch Size: 3.8KiB
<https://file.savannah.gnu.org/file/bug45833-filewrapper-versions.patch?file_id=58224>
AGPL NOTICE
These attachments are served by Savane. You can download the corresponding
source code of Savane at
https://savannah.gnu.org/source/savane-5c89ea1de46466fa27ad9decaeba153e39db01be.tar.gz
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?45833>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
signature.asc
(application/pgp-signature, 228 B)
-----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQQk97aszIMMAvLLwm6qLAuaBUf3TgUCaYctkgAKCRCqLAuaBUf3 TnnNAP4yfLwDgR1R+CrxhlX1to74sE9UeXdSNljjynR/W/3reAD+PsZQdUXTG+W1 /RB04yu3Mv4EZcZqiUPan+PFUkQuhwk= =ycmW -----END PGP SIGNATURE-----