[bug #67985] image: failing unit test in bwconncomp

Please use the bug tracker to post updates to a bug report.  The mailing list is intended as a read-only notification stream.  Info posted to this mailing list address won't appear in the tracker database where it is most useful.

Update of bug #67985 (group octave):

              Item Group:                    None => Regression
                  Status:                    None => Patch Submitted
        Operating System:               GNU/Linux => Any

    _______________________________________________________

Follow-up Comment #1:

Please review the patch:

diff -r 3edc1ed9d96d src/bwconncomp.cc
--- a/src/bwconncomp.cc        Sun Feb 08 22:42:01 2026 +0200
+++ b/src/bwconncomp.cc        Tue Feb 10 08:11:12 2026 +0200
@@ -28,6 +28,7 @@

 #include <octave/oct.h>
 #include <octave/oct-map.h>
+#include <octave/ov-struct.h>

 #include "connectivity.h"
 using namespace octave_image_pkg;
@@ -361,7 +362,10 @@
   if (nargin < 2 || nargin > 3)
     print_usage ();

-  boolNDArray BW = args(0).bool_array_value ();
+  if (args(0).is_string())
+    error ("bwareaopen: image BW must be a numeric or logical array");
+
+  boolNDArray BW = args(0).xbool_array_value ("bwareaopen: image BW must be a
numeric or logical array");

   const std::vector<octave_idx_type>::size_type lim = args(1).idx_type_value
();
   if (lim < 0)




    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?67985>

_______________________________________________
נשלחה הודעה דרך Savannah
https://savannah.gnu.org/

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQQk97aszIMMAvLLwm6qLAuaBUf3TgUCaYunRQAKCRCqLAuaBUf3
TgaIAQD8LnFWisL+W6Ey7qr1xZ9njc1Icw4orH7gD7eELCIrkAEAv6qoFDQS8lZQ
u1Ad9TqhPJZiayA5BHAIYAYx2CQHFAQ=
=34rG
-----END PGP SIGNATURE-----