[bug #68091] Inefficient Integer Data Loading from MAT-Files
foreverallama <[email protected]>
| Newsgroups | gmane.comp.gnu.octave.bugs |
|---|---|
| Message-ID | <[email protected]> |
Please use the bug tracker to post updates to a bug report. The mailing list is intended as a read-only notification stream. Info posted to this mailing list address won't appear in the tracker database where it is most useful.
Follow-up Comment #8, bug #68091 (group octave):
I tried it out the way you suggested, calling the template as follows:
using storage_type = typename
mat5_type<static_cast<mat5_data_type(type)>::type;
read_mat5_integer_data<storage_type>(is, re.rwdata(), n, swap);
However, it doesn't look like it's compiling. In the
"OCTAVE_MAT5_INTEGER_READ" macro, we get the type of underlying data from
"read_mat5_tag". So I think "type" becomes a runtime variable instead.
I guess we could move the "switch (type)" block from "read_mat5_integer_data"
to "OCTAVE_MAT5_INTEGER_READ", but we wouldn't really need the dtype mapping
with "mat5_data_type" in this case.
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?68091>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
signature.asc
(application/pgp-signature, 228 B)
-----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQQk97aszIMMAvLLwm6qLAuaBUf3TgUCaaWCjgAKCRCqLAuaBUf3 ThgvAQDYKZrcvoCgmFKW2E6UeqGfg/+6kKQ1HvAUYsuFQZIuXAEAiVxoXbFDMNLY bOs5rPkwJWZdgEJ58myP08maWvlbTw8= =+mD3 -----END PGP SIGNATURE-----