[bug #68150] Axis labels should be displayable also for invisible axes objects
Rik <[email protected]>
| Newsgroups | gmane.comp.gnu.octave.bugs |
|---|---|
| Message-ID | <[email protected]> |
Please use the bug tracker to post updates to a bug report. The mailing list is intended as a read-only notification stream. Info posted to this mailing list address won't appear in the tracker database where it is most useful.
Update of bug #68150 (group octave):
Status: In Progress => Patch Submitted
_______________________________________________________
Follow-up Comment #15:
@Pantxo: Can you review patch submitted here?
It adds hidden property *"visiblemode"* to all graphics objects. The code is
a little bit ugly because there is now an automatic updater which changes
*"visiblemode"* to *"manual"* whenever *set()* is called on *"visible"*
property. This requires making the change to *"visible"* and then resetting
*"visiblemode"* to *"auto"*.
void
axes::properties::update_visible ()
{
- xset (m_xlabel.handle_value (), "visible",
- is_visible () ? "on" : "off");
- xset (m_ylabel.handle_value (), "visible",
- is_visible () ? "on" : "off");
- xset (m_zlabel.handle_value (), "visible",
- (is_visible () && ! m_is2D) ? "on" : "off");
+ if (xget (m_xlabel.handle_value (), "visiblemode").string_value () ==
"auto")
+ {
+ xset (m_xlabel.handle_value (), "visible", is_visible () ? "on" :
"off");
+ xset (m_xlabel.handle_value (), "visiblemode", "auto");
+ }
+
+ if (xget (m_ylabel.handle_value (), "visiblemode").string_value () ==
"auto")
+ {
+ xset (m_ylabel.handle_value (), "visible", is_visible () ? "on" :
"off");
+ xset (m_ylabel.handle_value (), "visiblemode", "auto");
+ }
+
+ if (xget (m_zlabel.handle_value (), "visiblemode").string_value () ==
"auto")
+ {
+ xset (m_zlabel.handle_value (), "visible",
+ (is_visible () && ! m_is2D) ? "on" : "off");
+ xset (m_zlabel.handle_value (), "visiblemode", "auto");
+ }
}
(file #58390)
_______________________________________________________
Additional Item Attachment:
Name: zlabel.diff Size: 2.8KiB
<https://file.savannah.gnu.org/file/zlabel.diff?file_id=58390>
AGPL NOTICE
These attachments are served by Savane. You can download the corresponding
source code of Savane at
https://savannah.gnu.org/source/savane-9b684d621d606340ec3f8b1a290873daf3ff5474.tar.gz
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?68150>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
signature.asc
(application/pgp-signature, 228 B)
-----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQQk97aszIMMAvLLwm6qLAuaBUf3TgUCacEkkgAKCRCqLAuaBUf3 TuOIAP9o3kabtELvtGSF6CQiNNrypxeQn6b8C7pEIi5sg/7ITgD6A21HbpylfzrB Y/Fr0gc6l+wbh4EQQi8tCHE0MIHUiAs= =IvnR -----END PGP SIGNATURE-----