[bug #68121] convert isequal to built-in function for performance

Please use the bug tracker to post updates to a bug report.  The mailing list is intended as a read-only notification stream.  Info posted to this mailing list address won't appear in the tracker database where it is most useful.

Follow-up Comment #11, bug #68121 (group octave):

ok - reading through the patches

1) commit message doesn't need the narrative after the files list. simply list
the files/functions changed and for each one describe any changes. see
https://wiki.octave.org/Commit_message_guidelines

2) i guess it doesn't have the test mentioned in comment #10 and passes all
tests because... where are the tests? you don't seem to have added any.  Tests
for most m-file functions are at the end of the m-files, so removing the
m-files removed those tests. All of those tests need to be added back in
somewhere, plus any new ones to cover cases not previously addressed. See 

https://wiki.octave.org/Add_BIST_tests_for_octave_functions_written_in_C


Thanks for taking the time to report this bug.

This bug report isn't very useful because it doesn't describe the
bug well. If you have time and can still reproduce the bug,
please read http://www.octave.org/bugs.html and add a description
of how to reproduce this bug.

You'll also need to add a stack trace; please see
http://wiki.octave.org/Debugging_Octave for more information
about how to do so.

Thanks in advance!



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?68121>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQQk97aszIMMAvLLwm6qLAuaBUf3TgUCacwJ1gAKCRCqLAuaBUf3
ThTwAQDtA9OOjhJE83p/CY6o06QVdflg/v/PflQJM6KTXGMG0wD/bI/PG1JpEJ9e
KUZTi70dJmvaH94X+KFZYH5xRUHymA0=
=8Cbv
-----END PGP SIGNATURE-----