[bug #68121] convert isequal to built-in function for performance

Please use the bug tracker to post updates to a bug report.  The mailing list is intended as a read-only notification stream.  Info posted to this mailing list address won't appear in the tracker database where it is most useful.

Update of bug #68121 (group octave):

                  Status:         Patch Submitted => In Progress

    _______________________________________________________

Follow-up Comment #24:

Here is your patch header:


Convert isequal and isequaln to built-in C++ functions (bug #68121)

* libinterp/corefcn/isequal.cc: New file with C++ implementation.
  Add support for numeric types, complex, sparse (real, complex, bool).
  Fix double/single precision comparison.
  Fix multi-row character matrix comparison.
  Fix mixed type comparison.
  Add optimization for same object comparison.
  Add 13 BIST tests.
* libinterp/corefcn/module.mk: Add isequal.cc to build.
* scripts/general/module.mk: Remove isequal.m and isequaln.m.
* scripts/general/isequal.m, scripts/general/isequaln.m: Removed.
* NEWS: Add entry for version 12.


- You say you touch 6 files.  your patch only touches 3, the new isequal.cc
and the two module.mk files. Assuming you're trying to work across changes you
committed in multiple steps, perhaps you can determine what revision your
first commit was against and run something like:
hg diff -r <clean-revision> > complete_patch.patch

that assumes you haven't pulled any other changes in between your changes.
Otherwise, you could try copying all changed files outside of the sourcetree,
revert to a clean, unmodified source, copy those changed files back in, delete
the two deleted files, do an hg diff to verify _only_ your intended changes
are now present in the diff and you aren't undoing anyone elses changes, then
do a single commit for all 6 files and use hg export to make a new patch that
captures just your changes to all 6 files.

sorry if this is burdensome, but i'm guessing you're used to git the workflow
is a bit different here.

- Format: please don't use linebreaks for separate changes in a single file.
just continue the sentences as a single "bullet" for that file.

- Since you need to be able to return to a clean state to clean up your patch,
it would be useful for you to generate clean and changed benchmarks for
comparison since the primary argument here is for performance improvement.

changing status back to in-progress


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?68121>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQQk97aszIMMAvLLwm6qLAuaBUf3TgUCac/HVAAKCRCqLAuaBUf3
Tnq0AP4mXe9WwuW5key86E0A96oYbQIUZELNzn2LyYWmdnnXHQD+LyYljG5NXaNI
cxz1avJ8mAogeyLPjGccpsLKgESnYwU=
=iBIH
-----END PGP SIGNATURE-----