[bug #67845] classdef constructors do not support multiple arguments

Thomas <[email protected]>
Newsgroups gmane.comp.gnu.octave.bugs
Message-ID <[email protected]>
Please use the bug tracker to post updates to a bug report.  The mailing list is intended as a read-only notification stream.  Info posted to this mailing list address won't appear in the tracker database where it is most useful.

Follow-up Comment #6, bug #67845 (group octave):

Hi Markus,

I removed the commented out block (sloppy on my part to leave it in), added a
line break between `octave_value_list` and `construct_object`, and changed the
classdef files to use Octave-specific syntax.

You are correct about `run_constructor`, most of the code was indented further
because I placed the `if (! default_initialize)` guard around the code.

Regarding "previous test, but with handle classes": grammatically it should be
"previous test, but with a handle class" if a singular handle class is being
used -- but because there's the possibility of a test using more than one
handle class at a time, then I defaulted to the plural case of "handle
classes". However I really don't have strong feelings either way, in fact I'm
not even sure if I like the convention of saying "previous test", because that
forces the tests to have a dependence on ordering. However, if I were to
change my current convention, I would apply that change to all the tests I
wrote in the entire classdef.tst file. I think it's okay as it is for now.

This change should probably go on the dev branch.

(file #58444)

    _______________________________________________________

Additional Item Attachment:

Name: bug67845_v2.patch              Size: 20KiB
    <https://file.savannah.gnu.org/file/bug67845_v2.patch?file_id=58444>


    AGPL NOTICE

These attachments are served by Savane. You can download the corresponding
source code of Savane at
https://savannah.gnu.org/source/savane-f290f6b25beb8cb99bbe243a6cd2c5fef79ffcde.tar.gz


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?67845>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
signature.asc (application/pgp-signature, 228 B)
-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQQk97aszIMMAvLLwm6qLAuaBUf3TgUCac/LUgAKCRCqLAuaBUf3
TnkSAQCeJjxgvrSDxILhiEeuPhVzVVcGKRVvobnc2du5EBIuSgEApKPxrN69IGCm
IOTvE7Ij1s5GR3T2M/tS9FAoWOjmWgI=
=7nW7
-----END PGP SIGNATURE-----
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.